New issue
Advanced search Search tips

Issue 673997 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Recipe engine should use utf-8 when decoding parameters JSON

Project Member Reported by vadimsh@chromium.org, Dec 14 2016

Issue description

Using default 'unicode' is surprising. Recipes generally don't deal with exotic languages or emojis (especially in command line), utf-8 makes more sense.
 
Components: Infra
Status: Untriaged (was: Unconfirmed)

Comment 3 by mmoss@chromium.org, Dec 16 2016

Components: -Infra

Comment 4 by estaab@chromium.org, Dec 16 2016

Cc: martiniss@chromium.org
Stephen, do you know if we need to use unicode instead of utf-8? should we switch it?

Comment 5 by estaab@chromium.org, Dec 16 2016

Owner: martiniss@chromium.org
Status: Assigned (was: Untriaged)
No real reason we picked one or the other. I can change it.

Unicode is frustrating though, it keeps breaking :(
Some context: some Fuchsia recipes needed an adjustment for parameters definition (from  List(str) to List(basestring)). 'unicode' was unexpected for them there.
Oh ok, I see. We can make that a str if that's easier. Although basestring is more correct, right?
Mergedinto: 689886
Status: Duplicate (was: Assigned)

Sign in to add a comment