New issue
Advanced search Search tips

Issue 673995 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove or update icon in upgrade notification bubbles

Project Member Reported by est...@chromium.org, Dec 14 2016

Issue description

They're still using assets and no longer match the app menu icons as they once did. The attached screenshot shows what it would look like if we update the icon. I actually think the icons look a bit silly as the same image is used twice in close proximity. Can we just get rid of the one in the bubble?

for reference, you can see this bubble with
chrome --simulate-outdated
 
Oi1MToCYCWd.png
20.1 KB View Download

Comment 1 by est...@chromium.org, Dec 14 2016

and for reference, this is what it looks like in today's world, without updating the icon. It's perhaps preferable to stay with the square, but the color is painfully different and I still think two identical or near-identical icons are unnecessary.
fSUD1pbskZ9.png
18.0 KB View Download

Comment 2 by hwi@chromium.org, Dec 14 2016

Per Harmony spec, Yes to removing the icon. Also, here's the shorter text suggested:

Chromium couldn't update to the latest version, so you're missing out on new features and security fixes.


Comment 3 by est...@chromium.org, Dec 14 2016

FWIW I think the reason the text in this particular bubble is a little lengthy is that it's explaining the rare case that an update failed and you have to reinstall completely (whereas normally Chrome updates itself and you just restart).

Comment 4 by hwi@chromium.org, Dec 14 2016

Since the button says "Reinstall Chromium", we might not need to repeat "You need to manually reinstall Chromium." in the body text. Do you feel differently? 

Comment 5 by est...@chromium.org, Dec 14 2016

I don't feel particularly strongly, but I do think the emphasis on manual intervention is relevant.

Comment 6 by hwi@chromium.org, Dec 14 2016

Got it. Shall we remove the icon for this bug first?

Since we have our UX writer now, we can add this to one of string review asks in Q1. I'll file a separate bug for any new string update.

Comment 7 by est...@chromium.org, Dec 15 2016

yes, I'll remove the icon. Thanks for following up on the string.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c821f28d145007603d0c1881075dd6ddbc97cf86

commit c821f28d145007603d0c1881075dd6ddbc97cf86
Author: estade <estade@chromium.org>
Date: Thu Dec 15 03:58:05 2016

Remove last vestigial uses of "update needed" png assets.

They were out of date, and in some cases redundant. Remove
the redundant uses completely and replace the others with
references to the vector versions.

BUG= 673995 

Review-Url: https://codereview.chromium.org/2576643002
Cr-Commit-Position: refs/heads/master@{#438728}

[delete] https://crrev.com/fcf5015deccb246d2dca3c8037db8b6c8a234547/chrome/app/theme/default_100_percent/common/update_menu_severity_high.png
[delete] https://crrev.com/fcf5015deccb246d2dca3c8037db8b6c8a234547/chrome/app/theme/default_100_percent/common/update_menu_severity_low.png
[delete] https://crrev.com/fcf5015deccb246d2dca3c8037db8b6c8a234547/chrome/app/theme/default_100_percent/common/update_menu_severity_medium.png
[delete] https://crrev.com/fcf5015deccb246d2dca3c8037db8b6c8a234547/chrome/app/theme/default_200_percent/common/update_menu_severity_high.png
[delete] https://crrev.com/fcf5015deccb246d2dca3c8037db8b6c8a234547/chrome/app/theme/default_200_percent/common/update_menu_severity_low.png
[delete] https://crrev.com/fcf5015deccb246d2dca3c8037db8b6c8a234547/chrome/app/theme/default_200_percent/common/update_menu_severity_medium.png
[modify] https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86/chrome/browser/recovery/recovery_install_global_error.cc
[modify] https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86/chrome/browser/ui/views/critical_notification_bubble_view.cc
[modify] https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86/chrome/browser/ui/views/critical_notification_bubble_view.h
[modify] https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86/chrome/browser/ui/views/outdated_upgrade_bubble_view.cc
[modify] https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86/chrome/browser/ui/views/outdated_upgrade_bubble_view.h

Comment 9 by est...@chromium.org, Dec 15 2016

Status: Fixed (was: Assigned)
I fixed this for the pictured bubble. The recovery install global error (another similar and hopefully very rare bubble) still has an icon because there's code elsewhere that asserts that to be the case. I'll leave that one to the Harmony folks.

Sign in to add a comment