On Dec 13 2016 after users update Chrome Dev with the above build and then go to Downloads, two downloads are showing there pending forever. |
|||||||||
Issue descriptionVersion: 57.0.2950.3 OS: Android 6.0.1 Device: Nexus 7 On Dec 13 2016 after users update Chrome Dev with the above build and then go to Downloads, two downloads are showing there pending forever. What steps will reproduce the problem? (1) On Dec 13 2016, Internet is on, go to Play Store (2) Find Chrome Dev and click Update (3) After Update is finished, open Chrome Dev (4) Go to Downloads What is the expected result? Nothing should show there as users have not done anything except just opening Chrome Dev. What happens instead? One download is showing as Download pending for Wednesday, Novemeber 30, 2016. The other download is showing as Download pending for Monday, Novemeber 28, 2016. Please check out the attached screenshots
,
Dec 14 2016
,
Dec 14 2016
Could you please open chrome:offline-internal and attach a copy of it here? Is this reproducible?
,
Dec 14 2016
Dan, I checked on the device, and there are no pending requests for offline pages, so this is either some props put in for development or source of these 2 items is downloads, hence assigning it to you. On a related note, I was not able to observer any state related pending offline page requests. Still work in progress I suppose...
,
Dec 14 2016
Should be fixed by a CL I just landed for 658246. Problem is that the downloads backend has a bunch of entries that are unresumable and shouldn't be shown.
,
Dec 15 2016
... and I've found another case where this can happen but am not sure why. Re-opening this one instead of marking it as a dupe since it's easier to track.
,
Dec 15 2016
Looks like a bad combination of how Download Home now has to go through Download Notifications to act on anything. Because the notifications aren't ever added for downloads the Download Home/DownloadHistory backend knows about, we can't control them. + Min
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/464f8dff920bd0b33f58e74779b8dd9a22a9f58c commit 464f8dff920bd0b33f58e74779b8dd9a22a9f58c Author: dfalcantara <dfalcantara@chromium.org> Date: Mon Dec 19 19:47:35 2016 [Downloads] DownloadNotificationService action fallback DownloadNotificationService lags behind Download Home on learning about downloads that exist. Problematically, Download Home needs to act on downloads via DownloadNotificationService to ensure that notifications properly account for download updates. Currently, when DownloadNotificationService is told to do something for a download it doesn't know about, the Intent is dropped on the floor. Instead, fall back so that the DownloadManagerService is notified by DownloadNotificationService about actions triggered via Download Home. BUG= 673994 ,658246 Review-Url: https://codereview.chromium.org/2577303002 Cr-Commit-Position: refs/heads/master@{#439527} [modify] https://crrev.com/464f8dff920bd0b33f58e74779b8dd9a22a9f58c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/464f8dff920bd0b33f58e74779b8dd9a22a9f58c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
Dec 20 2016
Fix was landed, but I'm keeping this open and assigning to Min to take a look at what I did in #9.
,
Jan 24 2017
Fix is already landed, marking this as fixed |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jiewu@chromium.org
, Dec 14 20161.6 MB
1.6 MB View Download
1.3 MB
1.3 MB View Download
1.4 MB
1.4 MB View Download