New issue
Advanced search Search tips

Issue 673993 link

Starred by 1 user
Status: Duplicate
Merged: issue 663787
Owner:
tandrii@chromium.org
Closed: Dec 2016
Cc:
tandrii@chromium.org
tikuta@chromium.org
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

git_cl alphanumeric check is too strict.

Project Member Reported by d...@chromium.org, Dec 14 2016 
Is there a reason why we can't have periods, hyphens, or other sane characters in our CL titles? It makes naming masters a lot easier, and is something that we have done for a while now.

"Landing change for chromium.mac" => "Landing change for chromiummac".

I don't like this check. What is its motivation?

Comment 1 by tikuta@chromium.org, Dec 14 2016

Cc: aga...@chromium.org tikuta@chromium.org
Caused by this CL?
https://chromium-review.googlesource.com/c/419330/

Anyway, I prefer not to set patchset title.
I do not want to press return key while running 'git cl upload'.

Comment 2 by aga...@chromium.org, Dec 14 2016

Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Re comment 1: This is the same behavior as Rietveld, which prompts for a patchset title, and offers the most recent commit message as the default. The one difference is that the gerrit implementation was asking on initial upload as well as additional patchset upload; I'm fixing that today.

Re the original complaint: I think tandrii has the most background on this. It has to do with the format used for supplying the patchset title (it's built into the ref that git pushes to) forcing limitations on the characters it can accept.

Comment 3 by tandrii@chromium.org, Dec 14 2016

Mergedinto: 663787
Status: Duplicate (was: Assigned)
Yep, too restrictive indeed. KI.
►

Sign in to add a comment