DevTools: violation warnings pop up in sources while debugging |
||||||
Issue description
run this:
eval(`function foo() {
debugger;
}
setTimeout(foo, 1000);
//# sourceURL=test.js`);
resume in two seconds.
,
Dec 14 2016
The fix is safe.
,
Dec 15 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08525f40da9cafaeaa6e4b89cd49dbe34d02a5b5 commit 08525f40da9cafaeaa6e4b89cd49dbe34d02a5b5 Author: pfeldman <pfeldman@chromium.org> Date: Thu Dec 15 20:24:33 2016 DevTools: don't report violations in the error/warning counter. BUG= 673984 Review-Url: https://codereview.chromium.org/2573303002 Cr-Commit-Position: refs/heads/master@{#438910} [modify] https://crrev.com/08525f40da9cafaeaa6e4b89cd49dbe34d02a5b5/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
,
Dec 19 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 20 2016
Issue 673715 has been merged into this issue.
,
Dec 23 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3 2017
Your change has been approved for M56. Beta RC cut is scheduled at 3.00 PM today 01/03, please merged the CL ASAP. Also provide us with the steps to verify the fix.
,
Jan 5 2017
Gentle reminder for merge.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b11336f1f0d632764495ee40b85debc0d2b32558 commit b11336f1f0d632764495ee40b85debc0d2b32558 Author: Pavel Feldman <pfeldman@chromium.org> Date: Thu Jan 05 20:16:36 2017 DevTools: violation warnings pop up in sources while debugging BUG= 673984 Review-Url: https://codereview.chromium.org/2575723002 Cr-Commit-Position: refs/heads/master@{#438415} (cherry picked from commit 1a7c8ad0c25e9050ba74d00494590c35a8553735) Review-Url: https://codereview.chromium.org/2612903006 . Cr-Commit-Position: refs/branch-heads/2924@{#682} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/b11336f1f0d632764495ee40b85debc0d2b32558/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64352a3ec24c63f56e7be7a4cfc0b5f40f0c01ec commit 64352a3ec24c63f56e7be7a4cfc0b5f40f0c01ec Author: Pavel Feldman <pfeldman@chromium.org> Date: Thu Jan 05 20:18:28 2017 DevTools: don't report violations in the error/warning counter. BUG= 673984 Review-Url: https://codereview.chromium.org/2573303002 Cr-Commit-Position: refs/heads/master@{#438910} (cherry picked from commit 08525f40da9cafaeaa6e4b89cd49dbe34d02a5b5) Review-Url: https://codereview.chromium.org/2617003002 . Cr-Commit-Position: refs/branch-heads/2924@{#683} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/64352a3ec24c63f56e7be7a4cfc0b5f40f0c01ec/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
,
Jan 31 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 14 2016