New issue
Advanced search Search tips

Issue 673981 link

Starred by 3 users
Status: Fixed
Owner:
ericrk@chromium.org
Closed: Dec 2016
Cc:
clamy@chromium.org
vmp...@chromium.org
ericrk@chromium.org
enne@chromium.org
arthurso...@chromium.org
cblume@chromium.org
khushals...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Hitting DCHECK(draw_image_.image()->isLazyGenerated())

Project Member Reported by chcunningham@chromium.org, Dec 14 2016 
Steps to repro:
0. Build with DCHECKS on (in my case, I build release, but dcheck_always_on = true).

1. Go to this page
http://dashif.org/reference/players/javascript/v2.3.0/samples/dash-if-reference-player/index.html

2. Delete the default stream URL in the input box near the top.

3. Paste the following url https://gdwproductionmedia.streaming.mediaservices.windows.net/b29d4f2f-3682-4124-8340-92b1cc4ee4a9/c1271606-cbf9-4d06-8a7c-ab9c27f5a258.ism/manifest(format=mpd-time-csf)

4. Observe DCHEK

Comment 1 by chcunningham@chromium.org, Dec 14 2016

Labels: OS-Linux

Comment 2 by chcunningham@chromium.org, Dec 14 2016 

Not tested on other platforms.

Comment 3 by vmp...@chromium.org, Dec 14 2016

Components: Internals>Compositing>Images
Labels: -Pri-2 Hotlist-ImageWG Pri-1
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
We're missing checks for lazy images in the newly added draw functions in the hijack canvas

Check failed: draw_image_.image()->isLazyGenerated(). 
#0 0x7f7cdaadc4be base::debug::StackTrace::StackTrace()
#1 0x7f7cdab49a0f logging::LogMessage::~LogMessage()
#2 0x7f7cd130c809 cc::(anonymous namespace)::ScopedDecodedImageLock::ScopedDecodedImageLock()
#3 0x7f7cd130d02c cc::(anonymous namespace)::ScopedImagePaint::TryCreate()
#4 0x7f7cd130cdf2 cc::ImageHijackCanvas::onDrawRect()

This is due to crrev.com/6dfd1ba1efd6d4 Eric, can you take a look please?
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0cdd34fa6a729f4366e69b13a382c4f1943f3fd

commit d0cdd34fa6a729f4366e69b13a382c4f1943f3fd
Author: ericrk <ericrk@chromium.org>
Date: Wed Dec 14 22:23:06 2016

ImageHijackCanvas should skip non-lazy images from SkImageShader

ImageHijack canvas can currently hit a DCHECK when we try to process
images from SkImageShaders, as it handles them even if they are
non-lazy. Non-lazy images should be skipped.

BUG= 673981 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2572783005
Cr-Commit-Position: refs/heads/master@{#438650}

[modify] https://crrev.com/d0cdd34fa6a729f4366e69b13a382c4f1943f3fd/cc/BUILD.gn
[modify] https://crrev.com/d0cdd34fa6a729f4366e69b13a382c4f1943f3fd/cc/playback/image_hijack_canvas.cc
[modify] https://crrev.com/d0cdd34fa6a729f4366e69b13a382c4f1943f3fd/cc/playback/image_hijack_canvas.h
[add] https://crrev.com/d0cdd34fa6a729f4366e69b13a382c4f1943f3fd/cc/playback/image_hijack_canvas_unittest.cc

Comment 5 by ericrk@chromium.org, Dec 14 2016

Status: Fixed (was: Assigned)

Comment 6 by vmp...@chromium.org, Jan 20 2017

Cc: arthurso...@chromium.org clamy@chromium.org
 Issue 672514  has been merged into this issue.
►

Sign in to add a comment