New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673955 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Apr 2017
Cc:
chanli@chromium.org
lijeffrey@chromium.org
█ robert...@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Should pick a build number with a Swarming task to refer to

Project Member Reported by st...@chromium.org, Dec 14 2016 
Traceback (most recent call last):
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:2ed13cc.397243552188023172/first_party/pipeline_utils/appengine_third_party_pipeline_python_src_pipeline/pipeline.py", line 2158, in evaluate
    self, pipeline_key, root_pipeline_key, caller_output)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:2ed13cc.397243552188023172/first_party/pipeline_utils/appengine_third_party_pipeline_python_src_pipeline/pipeline.py", line 1113, in _run_internal
    return self.run(*self.args, **self.kwargs)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:2ed13cc.397243552188023172/waterfall/trigger_base_swarming_task_pipeline.py", line 160, in run
    assert len(swarming_task_items) > 0, 'No Swarming task was run.'
AssertionError: No Swarming task was run.


All logs are:
https://pantheon.corp.google.com/logs/viewer?project=findit-for-me&key1=waterfall-backend&key2=77a2064&logName=projects%2Ffindit-for-me%2Flogs%2Fappengine.googleapis.com%252Frequest_log&minLogLevel=0&expandAll=false&resource=gae_app&filters=text:%22No%20Swarming%20task%20was%20run.%22&timestamp=2016-12-06T04:21:46.298041000Z

Comment 1 by st...@chromium.org, Dec 14 2016

Components: -Tools>Test>FindIt Tools>Test>FindIt>Flakiness

Comment 2 by st...@chromium.org, Dec 14 2016

Summary: Should pick a build number with a Swarming task to refer to (was: A lot of failures to trigger a new Swarming task)
The root cause seems to be that there is no Swarming task run in the given build.

So after a build number is selected, we'd better check that there is a corresponding Swarming task.

There might be some corner cases:
1. the step is newly-added
2. the build turned purple (infra exception) before the step starts
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/468b86fa82da680d005a7ccc6fea20d418bcd6f2

commit 468b86fa82da680d005a7ccc6fea20d418bcd6f2
Author: Shuotao Gao <stgao@chromium.org>
Date: Wed Dec 14 21:08:48 2016

[Findit] Monitor when no Swarming task to refer to.

BUG= 673955 
R=chanli, lijeffrey

Change-Id: I9a86f097a2709126163b2c41f54782e3efaff111
Reviewed-on: https://chromium-review.googlesource.com/419704
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/468b86fa82da680d005a7ccc6fea20d418bcd6f2/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py

Comment 4 by st...@chromium.org, Apr 24 2017

Owner: chanli@chromium.org
Status: Fixed (was: Available)
IIRC, chan has fixed this.

Chan: if not, please reopen.

Comment 5 by st...@chromium.org, Apr 24 2017 

 Issue 673034  has been merged into this issue.

Comment 6 by chanli@chromium.org, Apr 24 2017 

Should've been fixed
►

Sign in to add a comment