New issue
Advanced search Search tips

Issue 673953 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 671375



Sign in to add a comment

Replace most checkboxes with switches

Project Member Reported by bettes@chromium.org, Dec 14 2016

Issue description

Comment 1 by bettes@chromium.org, Dec 28 2016

From maxwalker@ regarding dialogs coming from Settings (CBD, Add languages, etc)

"I'm not sure if on/off switches make sense in the context of the CBD dialog. I think they work great to turn features or settings on/off at one go. However, CBD is a different kind of interaction: making a selection and then taking action on that selection. So I think checkboxes are the most suitable controls here."

-- 

So what we're saying is that because there's no "confirmation action" on Settings, switches are an acceptable interaction. But with dialogs, such as Add Language (Advanced > Languages > Add Languages) and CBD, a "confirmation action" is needed to confirm the selection.


Distinction (based on https://msdn.microsoft.com/windows/uwp/controls-and-patterns/toggles): 

Switches should be used for for binary settings when changes become effective immediately after the user changes them, for example turning a feature on or off.

Checkboxes should be used when the user has to perform extra steps for changes to be effective, for example indicating a selection from multiple items in a dialog.

Comment 3 by dbeam@chromium.org, Jan 4 2017

Cc: dbeam@chromium.org
Cc: msramek@chromium.org
Labels: Review-Privacy
Labels: -Review-Privacy privacy

Comment 6 by dbeam@chromium.org, Jan 4 2017

Owner: dbeam@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbe54c5a50804735b8407a0703515a1a39f78e8

commit 0fbe54c5a50804735b8407a0703515a1a39f78e8
Author: dbeam <dbeam@chromium.org>
Date: Fri Jan 06 02:46:31 2017

MD Settings: push controlled indicators totally to the right

This is for a better right key line now that controls are more
consistently on the right of md-settings.

R=dschuyler@chromium.org
BUG= 673953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2611183003
Cr-Commit-Position: refs/heads/master@{#441847}

[modify] https://crrev.com/0fbe54c5a50804735b8407a0703515a1a39f78e8/chrome/browser/resources/settings/controls/controlled_radio_button.html

Blocking: 671375
Labels: Hotlist-MD-Settings-General
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a9c64443887c1235b828b4797da27f3f633600f

commit 9a9c64443887c1235b828b4797da27f3f633600f
Author: dbeam <dbeam@chromium.org>
Date: Sat Jan 07 03:01:32 2017

MD Settings: simplify layout of system page

R=dschuyler@chromium.org
BUG= 673953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615613007
Cr-Commit-Position: refs/heads/master@{#442145}

[modify] https://crrev.com/9a9c64443887c1235b828b4797da27f3f633600f/chrome/browser/resources/settings/system_page/system_page.html

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1314396d75b72f1d0676f97fd8d39b59f6bbb3ba

commit 1314396d75b72f1d0676f97fd8d39b59f6bbb3ba
Author: dbeam <dbeam@chromium.org>
Date: Sat Jan 07 04:26:09 2017

MD Settings: re-use some iron-flex-layout classes to shrink checkboxes -> toggles diff

R=dschuyler@chromium.org
BUG= 673953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614063004
Cr-Commit-Position: refs/heads/master@{#442153}

[modify] https://crrev.com/1314396d75b72f1d0676f97fd8d39b59f6bbb3ba/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/1314396d75b72f1d0676f97fd8d39b59f6bbb3ba/chrome/test/data/webui/settings/metrics_reporting_tests.js

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7565ba94652c87be04cd80f3722d52b418342df

commit e7565ba94652c87be04cd80f3722d52b418342df
Author: dbeam <dbeam@chromium.org>
Date: Sat Jan 07 04:27:10 2017

MD Settings: push policy control indicators to right for checkboxes -> toggles transition

R=dschuyler@chromium.org
BUG= 673953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2616043002
Cr-Commit-Position: refs/heads/master@{#442154}

[modify] https://crrev.com/e7565ba94652c87be04cd80f3722d52b418342df/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/e7565ba94652c87be04cd80f3722d52b418342df/chrome/browser/resources/settings/privacy_page/privacy_page.html

Description: Show this description
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0811dbe5577e389b35e8bc42ff9d19da756de89c

commit 0811dbe5577e389b35e8bc42ff9d19da756de89c
Author: dbeam <dbeam@chromium.org>
Date: Wed Jan 11 17:45:33 2017

MD Settings: change most checkboxes to toggles (leave dialogs alone)

R=dschuyler@chromium.org
BUG= 673953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2617533003
Cr-Commit-Position: refs/heads/master@{#442947}

[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/android_apps_page/android_apps_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/date_time_page/date_time_page.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/device_page/pointers.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/internet_page/network_ip_config.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/internet_page/network_siminfo.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/android_apps_page_test.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/date_time_page_tests.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/metrics_reporting_tests.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/people_page_sync_page_test.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/privacy_page_test.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/search_page_test.js
[modify] https://crrev.com/0811dbe5577e389b35e8bc42ff9d19da756de89c/chrome/test/data/webui/settings/system_page_tests.js

Comment 15 by dbeam@chromium.org, Jan 12 2017

Summary: Replace most checkboxes with switches (was: Replace all checkboxes with switches)
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de09d362b972881698c15fc80d66fbb03c55adb

commit 7de09d362b972881698c15fc80d66fbb03c55adb
Author: dbeam <dbeam@chromium.org>
Date: Fri Jan 13 01:22:01 2017

MD Settings: add border between sync data type toggles

R=tommycli@chromium.org
BUG= 673953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2629743002
Cr-Commit-Position: refs/heads/master@{#443430}

[modify] https://crrev.com/7de09d362b972881698c15fc80d66fbb03c55adb/chrome/browser/resources/settings/people_page/sync_page.html

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43f4b93273c33a1a3c0ea483bca8559a8fd87e9

commit c43f4b93273c33a1a3c0ea483bca8559a8fd87e9
Author: dbeam <dbeam@chromium.org>
Date: Fri Jan 13 04:47:29 2017

MD Settings: add borders between toggle rows on basic/advanced pages

R=dschuyler@chromium.org
BUG= 673953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626993003
Cr-Commit-Position: refs/heads/master@{#443492}

[modify] https://crrev.com/c43f4b93273c33a1a3c0ea483bca8559a8fd87e9/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/c43f4b93273c33a1a3c0ea483bca8559a8fd87e9/chrome/browser/resources/settings/system_page/system_page.html

Comment 18 by dbeam@chromium.org, Jan 13 2017

Status: Fixed (was: Started)
let's file bugs if we find specific issues.  i'll bet there are more lurking

Sign in to add a comment