[default browser] Edit strings and string color |
|||||
Issue description1. Remove the "Cheers" from the string. 2. Make the text color Primary for both "default" and "this is a secondary..." strings https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Browser.png%3Fz=width
,
Jan 30 2017
,
Mar 16 2017
,
Mar 16 2017
bettes@ tbuckley@ there's also another state - when the browser fails to determine or set the default browser of the machine, it says "Google Chrome cannot determine or set the default browser.", which currently is also in the Secondary grey color. Should that be changed to Primary color too?
,
Mar 16 2017
,
Mar 16 2017
verified with bettes@ offline that the aforementioned state should also use primary color.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17d00a1b464a2761035b184cb46d24612829ffd6 commit 17d00a1b464a2761035b184cb46d24612829ffd6 Author: scottchen <scottchen@chromium.org> Date: Thu Mar 16 22:34:10 2017 MD Settings: Default browser message tweak. BUG= 673952 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2752993002 Cr-Commit-Position: refs/heads/master@{#457586} [modify] https://crrev.com/17d00a1b464a2761035b184cb46d24612829ffd6/chrome/app/settings_chromium_strings.grdp [modify] https://crrev.com/17d00a1b464a2761035b184cb46d24612829ffd6/chrome/app/settings_google_chrome_strings.grdp [modify] https://crrev.com/17d00a1b464a2761035b184cb46d24612829ffd6/chrome/browser/resources/settings/default_browser_page/default_browser_page.html
,
Mar 17 2017
,
Mar 17 2017
For the record, Yes to comment 4
,
Mar 17 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tbuck...@chromium.org
, Jan 30 2017Labels: Hotlist-MD-Settings-DefaultBrowser OS-Linux OS-Mac OS-Windows