New issue
Advanced search Search tips

Issue 673946 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 673948



Sign in to add a comment

[Bluetooth] Remove inline editing

Project Member Reported by bettes@chromium.org, Dec 13 2016

Issue description

Comment 1 by bettes@chromium.org, Dec 14 2016

Labels: OS-Chrome

Comment 2 by bettes@chromium.org, Dec 14 2016

Blockedon: 673948

Comment 3 by dbeam@chromium.org, Dec 14 2016

Blocking: 673948

Comment 4 by dbeam@chromium.org, Dec 14 2016

Blockedon: -673948
Labels: M-58
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
Cc: tbuck...@chromium.org dbeam@chromium.org bettes@chromium.org
Since this will improve performance of the main page, I will address this for 58 rather than optimizing the existing UX.

Alan, I think you mentioned moving Bluetooth to 'Basic' if we do this? If so, where should it be, under Internet?

Comment 7 by bettes@chromium.org, Jan 19 2017

Cc: sgabr...@chromium.org
+Sebastien to advise on the location of Bluetooth in the Basic section of settings
That's a great idea. Yes, under internet.

Comment 9 by tbuckley@google.com, Jan 25 2017

Labels: Hotlist-MD-Settings-Bluetooth Pri-2 Type-Bug
Cc: fukino@chromium.org
Status: Started (was: Assigned)
fukino@ - FYI. I don't think this will conflict with any of your changes. I just plan to introduce bluetooth.html for the main page, and move bluetooth_page.html to bluetooth_subpage.html.

fukino@ - I changed my mind, I am going to repurpose bluetooth_page.html and add bluetooth_subpage.html. I believe that the issue you were working on will not be impacted, but if so let me know and we can figure it out.

Hi Alan,
How can we pair new devices in the proposed new UI?

In previous mock ("Add device dialog" in https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Bluetooth.png%3Fz=width), we had a dialog to show unpaired devices.
However, in the new mock, we don't have button to show the dialog.

Should we show paired/unpaired devices in the sub page (like we do in system tray menu), or should we add a button to open up the dialog?
Failed to attache the screenshot with the system menu, in which we show paired devices and unpaired devices in the same list (with a separator)
Screenshot from 2017-01-30 18:53:52.png
68.7 KB View Download
I added a button (as shown in the screenshot) for now, based on Alan's suggestion, CL: https://codereview.chromium.org/2655043005/

 We could inline the dialog in a follow up CL, if we decide to go that route.

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecc211d2da5e50c3b4483849a325795fd0072baa

commit ecc211d2da5e50c3b4483849a325795fd0072baa
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Jan 31 19:08:18 2017

MD Settings: Bluetooth: Move device list to subpage

This CL:
* Moves the bulk of the Bluettoth UI to a subpage (see issue).
* Moves the (more compact) bletooth section to the Basic page,
below Internet, as requested by UX.
* Adds support for a spinner to settings-subpage (we will eventually use this for Internet also).

Review notes:
* pairingEvent_ and bluetoothPrivateOnPairingListener_ were moved to bluetooth-device-dialog where they are actually used.

BUG= 673946 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2655043005
Cr-Commit-Position: refs/heads/master@{#447287}

[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/app/settings_strings.grdp
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[add] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
[add] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/settings_page/settings_subpage.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/test/BUILD.gn
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/test/data/webui/settings/advanced_page_browsertest.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/test/data/webui/settings/basic_page_browsertest.js
[delete] https://crrev.com/a436fd0e674c0f13a3334f4c2bfbd04773b3372c/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
[add] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/test/data/webui/settings/fake_bluetooth.js
[modify] https://crrev.com/ecc211d2da5e50c3b4483849a325795fd0072baa/chrome/test/data/webui/settings/settings_subpage_browsertest.js

Status: Fixed (was: Started)
Status: Started (was: Fixed)
As per discussion, we also need to inline the pair devices dialog.

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5

commit 1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Feb 08 23:04:08 2017

MD Settings: Move bluetooth UI from dialog to subpage

This CL does the following:
1. Moves the list of paired devices from the dialog the subpage.
2. Updates the top level bluetooth page to be two lines (with enabled state in the second line) with a toggle switch (similar to Autofill settings or Manage paswords).
3. Moves the spinner to be in the same row as the 'Unpaired devices' subtitle in the subpage.

BUG= 673946 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676103002
Cr-Commit-Position: refs/heads/master@{#449123}

[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/app/settings_strings.grdp
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/test/data/webui/settings/fake_bluetooth.js
[modify] https://crrev.com/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5/chrome/test/data/webui/settings/fake_bluetooth_private.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9532.0.0, 60.0.3092.0

Sign in to add a comment