New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673944 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 673948
issue 157287



Sign in to add a comment

[Network] Remove inline editing

Project Member Reported by bettes@chromium.org, Dec 13 2016

Issue description

Comment 1 by bettes@chromium.org, Dec 14 2016

Labels: OS-Chrome

Comment 2 by bettes@chromium.org, Dec 14 2016

Blockedon: 673948

Comment 3 by dbeam@chromium.org, Dec 14 2016

Blocking: 673948

Comment 4 by dbeam@chromium.org, Dec 14 2016

Blockedon: -673948
To clarify for myself and potentially others (I had to re-read the proposal a few times to understand what was meant by "inline editing"), the proposal, as I understand it is (roughly):

Replace the inline expandable list of networks with a subpage.

Cc: steve...@chromium.org
Labels: M-59
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
Currently this is not a release blocker for MD Settings. Since there are no / minimal perforance benefits for Internet, this is not a priority for 58.

Comment 8 by tbuckley@google.com, Jan 25 2017

Labels: Hotlist-MD-Settings-Internet Pri-1 Type-Bug
Cc: tbuck...@chromium.org
Tom, is this a Pri-1 for 58, or can it wait for 59?

59 seems reasonable.
Note: When this is completed, the VPN Settings button in the System Tray should direct to the VPN subpage ( issue 692334 ).

Cc: khorimoto@chromium.org hansberry@chromium.org elizabethchiu@chromium.org
+ Instant Tether folks

Blocking: 157287
Labels: -M-59 M-58
I am going to knock this out for 58. The risk is pretty minimal, and it will improve performance. It is also going to block Tethering and other related UI soon.

Cc: durga.behera@chromium.org ajha@chromium.org dpa...@chromium.org kavvaru@chromium.org brajkumar@chromium.org
 Issue 688271  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0dbfbfadfa62bd03b0dac618105ebe77d09090

commit 3f0dbfbfadfa62bd03b0dac618105ebe77d09090
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Feb 27 18:59:51 2017

MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG= 673944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}

[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/fake_networking_private.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/internet_page_tests.js

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0dbfbfadfa62bd03b0dac618105ebe77d09090

commit 3f0dbfbfadfa62bd03b0dac618105ebe77d09090
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Feb 27 18:59:51 2017

MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG= 673944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}

[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/fake_networking_private.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/internet_page_tests.js

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0dbfbfadfa62bd03b0dac618105ebe77d09090

commit 3f0dbfbfadfa62bd03b0dac618105ebe77d09090
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Feb 27 18:59:51 2017

MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG= 673944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}

[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/fake_networking_private.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/internet_page_tests.js

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0dbfbfadfa62bd03b0dac618105ebe77d09090

commit 3f0dbfbfadfa62bd03b0dac618105ebe77d09090
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Feb 27 18:59:51 2017

MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG= 673944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}

[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/fake_networking_private.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/internet_page_tests.js

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0dbfbfadfa62bd03b0dac618105ebe77d09090

commit 3f0dbfbfadfa62bd03b0dac618105ebe77d09090
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Feb 27 18:59:51 2017

MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG= 673944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}

[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/fake_networking_private.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/internet_page_tests.js

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0dbfbfadfa62bd03b0dac618105ebe77d09090

commit 3f0dbfbfadfa62bd03b0dac618105ebe77d09090
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Feb 27 18:59:51 2017

MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG= 673944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}

[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/fake_networking_private.js
[add] https://crrev.com/3f0dbfbfadfa62bd03b0dac618105ebe77d09090/chrome/test/data/webui/settings/internet_page_tests.js

 Issue 696900  has been merged into this issue.
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b

commit 945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Mar 02 20:47:01 2017

MD Settings: Internet: Move network lists to a subpage

This CL:
* Moves the lists of networks and the associated logic
from network-summary-item to internet-subpage.
* Changes the network-summary listener pattern to match other usage.
* Adds missing aria-label for buttons and toggles.
* Fixes a bug in cr-network-icon causing it to show the security badge for disconnected summary items.
* Adds a separator bar before the subpage button in cr-network-list-item.

BUG= 673944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2720503006
Cr-Commit-Position: refs/heads/master@{#454368}

[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/app/settings_strings.grdp
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/internet_page.js
[add] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/internet_subpage.html
[add] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/internet_page/network_summary_item.js
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/test/data/webui/settings/fake_networking_private.js
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/chrome/test/data/webui/settings/internet_page_tests.js
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/ui/webui/resources/cr_elements/network/cr_network_icon.js
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/ui/webui/resources/cr_elements/network/cr_network_list.html
[modify] https://crrev.com/945290e9adf66a1cc7cd5a1fd089fe3ae3400a8b/ui/webui/resources/cr_elements/network/cr_network_list_item.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9534.0.0, 60.0.3092.0

Sign in to add a comment