New issue
Advanced search Search tips

Issue 673937 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Dec 2016
Cc:
dbeam@chromium.org
tbuck...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Inconsistent back/forward behavior in MD settings

Project Member Reported by rdevlin....@chromium.org, Dec 13 2016 
bugs: repro steps (I did X and expected Y but Z happened!)
1. visit chrome://md-settings
2. in the menu bar, click "search engine" - search subpage pops up.
3. click to go back - page goes back to the main page (good!)
4. click forward

Page doesn't go forward.  The url updates to be md-settings/search, but it doesn't get updated.

Seems to repro with most/all subpages.

-> dbeam for triage.

Comment 1 by dbeam@chromium.org, Dec 14 2016

Cc: tommycli@chromium.org
Status: Fixed (was: Assigned)
this is working for me on canary on Mac.

i think you might've been using an old version of chrome that accidentally navigates back twice when a dialog is open (we double handled popstate, whoops!)

Comment 2 by rdevlin....@chromium.org, Dec 14 2016

Summary: Inconsistent back/forward behavior in MD settings (was: [section, page, or dialog name here] followed by your feature or bug)
Whoops - somehow forgot the title.  Updated.

Re #1 - hmm... I was building from src, but src might have been a day or two old.  Was this fixed in the last 72 hours?

Comment 3 by dbeam@chromium.org, Dec 14 2016

Cc: -tommycli@chromium.org dbeam@chromium.org
Owner: tommycli@chromium.org
Status: Assigned (was: Fixed)
tommycli@: can you investigate?

Comment 4 by tommycli@chromium.org, Dec 14 2016 

Yeah I can check this out.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bc347f4d307c8a7c8e6f6664895dbf4c5af288a

commit 8bc347f4d307c8a7c8e6f6664895dbf4c5af288a
Author: tommycli <tommycli@chromium.org>
Date: Sat Dec 17 00:49:45 2016

MD Settings: Fix scrolling when navigating Forwards from BASIC page.

CL includes test.

BUG= 673937 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2582643002
Cr-Commit-Position: refs/heads/master@{#439263}

[modify] https://crrev.com/8bc347f4d307c8a7c8e6f6664895dbf4c5af288a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/8bc347f4d307c8a7c8e6f6664895dbf4c5af288a/chrome/test/data/webui/settings/basic_page_browsertest.js

Comment 6 by tommycli@chromium.org, Dec 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment