New issue
Advanced search Search tips

Issue 673936 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refer back to Jinja's *.tmpl file from the sources generated from Blink's IDL files

Project Member Reported by lukasza@chromium.org, Dec 13 2016

Issue description

After the big rename we will need to tweak Jinja's tmpl files, to account for renamed method names.  For example, in third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl we will need to change |toV8Impl| to |ToV8Impl|.

It would be great if the generated files contained a reference back to the Jinja's tmpl file used to generate them.  This would make it easier to identify the tmpl files that need tweaking.

This is a nice-to-have, although not-quite-blocking for  issue 578344  (tracking the "big rename" in Blink).

 
I tried to look at Jinja's documentation and couldn't figure out how to accomplish this (referring back to Jinja's *.tmpl file) only by tweaking third_party/WebKit/Source/bindings/templates/copyright_block.txt.  I see that I can kind of refer to my current template via {{self}}, but the only documented usage of {{self}} is to refer to other blocks in the same template.  I don't see a way to refer to the template that included me.

OTOH, maybe something like https://codereview.chromium.org/2569923003 is a reasonable way to move forward?  WDYT?





LGTMed.

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fccd34e5adef51e73c5c2eabecaf71419a891707

commit fccd34e5adef51e73c5c2eabecaf71419a891707
Author: lukasza <lukasza@chromium.org>
Date: Thu Dec 15 01:05:34 2016

Refer back to Jinja templates from the C++ code generated from IDL files.

After the changes, the generated code
(e.g. out/gn/gen/blink/core/dom/TouchInit.h)
will contain a comment similar to:

    // This file has been generated from the Jinja2 template in
    // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

BUG= 673936 

Review-Url: https://codereview.chromium.org/2569923003
Cr-Commit-Position: refs/heads/master@{#438690}

[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/scripts/code_generator.py
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/templates/copyright_block.txt
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.h
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
[modify] https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
lukasza@, do you think this is fixed?

Status: Fixed (was: Assigned)

Sign in to add a comment