New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673934 link

Starred by 1 user
Status: Fixed
Owner:
█ phulce@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Show cookies from all sub-resources in devtools

Project Member Reported by phulce@chromium.org, Dec 13 2016 
Chrome Version: 57.0.2950.0
OS: All

What steps will reproduce the problem?
(1) Visit a URL that loads an image from an external domain with cookies set (https://www.theverge.com).
(2) Open the Application > Cookies panel
(3) Select the main frame (https://www.theverge.com)

What is the expected result? Cookies for beacon.krxd.net and other domains with tracking pixels are present in the list

What happens instead? Only cookies for theverge.com and cookies matching the iframe domains are present
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e344cf0c658526a278eeae8817026b1a032b5633

commit e344cf0c658526a278eeae8817026b1a032b5633
Author: phulce <phulce@chromium.org>
Date: Fri Jan 06 18:56:26 2017

DevTools: Cookies panel toolbar changes

Paving the way to expose all relevant cookies per 673934.

* Adds filter bar with text match on name, value, and domain
* Converts invisible state buttons into disabled states

BUG= 673934 

Review-Url: https://codereview.chromium.org/2617043002
Cr-Commit-Position: refs/heads/master@{#441996}

[modify] https://crrev.com/e344cf0c658526a278eeae8817026b1a032b5633/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
[modify] https://crrev.com/e344cf0c658526a278eeae8817026b1a032b5633/third_party/WebKit/Source/devtools/front_end/resources/resourcesPanel.css
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36ab298cb853d6bf6366065dee9821dfd42c69c3

commit 36ab298cb853d6bf6366065dee9821dfd42c69c3
Author: phulce <phulce@chromium.org>
Date: Mon Jan 23 20:23:33 2017

DevTools: Fix getCookies to report for all resources

* Changes getCookies protocol method to accept a set of urls
* Changes getCookiesAsync to request specific urls from a specific target
* Changes CookieItemsView to fetch cookies for all subresources of the frame

BUG= 673934 

Review-Url: https://codereview.chromium.org/2623063003
Cr-Commit-Position: refs/heads/master@{#445464}

[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json
[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[modify] https://crrev.com/36ab298cb853d6bf6366065dee9821dfd42c69c3/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

Comment 3 by phulce@chromium.org, Jan 26 2017

Status: Fixed (was: Started)

Comment 4 by kayce@google.com, Jan 26 2017

Labels: DevTools-Release-Notes-Feature
►

Sign in to add a comment