New issue
Advanced search Search tips

Issue 673930 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug-Regression



Sign in to add a comment

FindTest_testBackKeyDoesNotDismissFindWhenImeIsPresent is flaky

Project Member Reported by nyquist@chromium.org, Dec 13 2016 
Typically on the "Lollipop Phone Tester" bot. Example build failure:
https://luci-milo.appspot.com/buildbot/chromium.android/Lollipop%20Phone%20Tester/8453

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.widget.findinpage.FindTest%23testBackKeyDoesNotDismissFindWhenImeIsPresent

Example stack trace from failure:
org.chromium.chrome.browser.widget.findinpage.FindTest#testBackKeyDoesNotDismissFindWhenImeIsPresent (run #1):
junit.framework.AssertionFailedError: IME is not getting shown!
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:112)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:133)
	at org.chromium.chrome.browser.widget.findinpage.FindTest.waitForIME(FindTest.java:394)
	at org.chromium.chrome.browser.widget.findinpage.FindTest.testBackKeyDoesNotDismissFindWhenImeIsPresent(FindTest.java:366)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)


Assigning to tedchoc@ for triage.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11b95e222e20c213b3ee16286c7374d9c067ea09

commit 11b95e222e20c213b3ee16286c7374d9c067ea09
Author: nyquist <nyquist@chromium.org>
Date: Wed Dec 14 00:35:37 2016

[android] Mark find-in-page test flaky

This marks the
FindTest#testBackKeyDoesNotDismissFindWhenImeIsPresent as flaky.
See bug for further description about flakiness.

BUG= 673930 

Review-Url: https://codereview.chromium.org/2567113005
Cr-Commit-Position: refs/heads/master@{#438362}

[modify] https://crrev.com/11b95e222e20c213b3ee16286c7374d9c067ea09/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java

Comment 2 by rsgav...@chromium.org, Jan 25 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a4e7fc0b02766b463af8cade5a4a7a247d4887

commit 21a4e7fc0b02766b463af8cade5a4a7a247d4887
Author: Ted Choc <tedchoc@google.com>
Date: Thu Jun 07 17:20:08 2018

Remove FlakyTest annotation from testBackKeyDoesNotDismissFindWhenImeIsPresent

Ran locally 50 times w/o flake.  This also cleans up the logging
and test prep to make it easier to detect systemic failures.

BUG= 673930 

Change-Id: I86349f9256ddc554c8de12d9dca80fc06458aa20
Reviewed-on: https://chromium-review.googlesource.com/1089649
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565314}
[modify] https://crrev.com/21a4e7fc0b02766b463af8cade5a4a7a247d4887/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java
[modify] https://crrev.com/21a4e7fc0b02766b463af8cade5a4a7a247d4887/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java

Comment 4 by tedc...@chromium.org, Jun 7 2018

Status: Fixed (was: Assigned)
As with all flaky android test fixes...48% confident this is addressed.
►

Sign in to add a comment