New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673928 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

[Snowflake] Unify & customize Clank tooltip for posterity

Project Member Reported by hwi@chromium.org, Dec 13 2016

Issue description

Logging the future to-do from today's discussion with dfalcantara@ during the review for the upcoming Credential Manager Account Chooser UI for PSL match cases. cc rolfe@, hannahs@, fyi.

===================================

What steps will reproduce the problem?
(1) Long press tab switcher icon or (?) icon from a setting screen (top right corner)
https://screenshot.googleplex.com/jZfcm6POmuG.png
(2) Tap on (?) icon from the CVC dialog (select a google account saved card from https://rsolomakhin.github.io/autofill/ > card form)
https://screenshot.googleplex.com/0EALkPmgOO7.png

What is the expected result?

Both (1) and (2) use Material Tooltip style (Spec:  https://material.google.com/components/tooltips.html#tooltips-tooltips-mobile )


What happens instead?

(1) uses very roundy container i.e. Android standard toast, non-material
(2) uses black bg container i.e. non-standard, non-material

Note:

A. This means the code for (2) should be updated once there's a unified code to point to. In doing so, please update the (?) icon to (i) (same as the one on the upcoming Credential Manager Account Chooser UI for PSL match cases)

B. As a potential side effect, the change may result in Android standard toast (e.g. https://screenshot.googleplex.com/AH6fRkOUDVD.png title bar long pressed shows 'URL copied' toast) to have the same style as the material tooltip (not the roundy container anymore). This assumes the code is shared between the toast and the tooltip. Either 'sharing the style' or 'starting separating tooltip style from the toast style' sounds fine either way at this point because the result will be the toast either to be more MD-like (better) or to stay as-is (not worse). 

C. Tooltip icons and gestures to open a tooltip may vary


 

Comment 1 by hwi@chromium.org, Dec 13 2016

Labels: -Type-Bug OS-Android Type-Feature
Components: UI>Browser>Mobile

Comment 3 by rolfe@chromium.org, Mar 29 2017

Cc: -hwi@chromium.org -rolfe@chromium.org
Removing dated designers. Hannahs is the go-to for questions.
Cc: dtrainor@chromium.org
+last person who touched text bubbles
Owner: hannahs@chromium.org
Summary: [Snowflake] Unify & customize Clank tooltip for posterity (was: Unify & customize Clank tooltip for posterity)
Assigning to me as a part of project snowflake
Owner: ----
Status: Untriaged (was: Assigned)
I believe this was updated but the tooltip is now a little off centered. We may need to update manually so updating to Untriaged for Eng to scope if this is something we can get in by EoY.
Screenshot_20181031-110028.png
364 KB View Download

Sign in to add a comment