chromite virtualenv wrapper infinite loop |
||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/10439/steps/Report/logs/stdio https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/10588/steps/Report/logs/stdio https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/10588 It seems like the virtualenv detection is faulty, causing the chromite virtualenv wrapper to keep recursing.
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9f03f5b7711bf6624e1febbd7bf84bbc46481d85 commit 9f03f5b7711bf6624e1febbd7bf84bbc46481d85 Author: Allen Li <ayatane@chromium.org> Date: Tue Dec 13 23:23:52 2016 Fix virtualenv environment detection There seems to be some combination of factors that cause the string matching of the VIRTUAL_ENV envvar to fail on trybots/pre-cq. Given that, I think its generally a bad idea to do path comparisons against the virtualenv environment and reverting back to a dumber, but more robust implementation of the virtualenv check using a magic variable. BUG= chromium:673926 TEST=Run bin/venv_check and unit tests Change-Id: Ifaafafc0abf5b079585a168f5d6a4b731c1a2d2e Reviewed-on: https://chromium-review.googlesource.com/419722 Commit-Ready: David Riley <davidriley@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/9f03f5b7711bf6624e1febbd7bf84bbc46481d85/scripts/virtualenv_wrapper.py [modify] https://crrev.com/9f03f5b7711bf6624e1febbd7bf84bbc46481d85/scripts/virtualenv_wrapper_unittest.py
,
Dec 15 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ayatane@chromium.org
, Dec 14 2016