MD Settings: Indicators for actionable rows that go somewhere |
||||||||||||||||||||||
Issue descriptionWe need some clarification on which icons should be used for certain actionable rows. Specifically, Keyboard needs some icons, and Storage Management may be using incorrect icons. BACKGROUND: [icons-1] On the main page, a small right arrow indicates that tapping the row navigates to a sub-page within that section. For example: [Mouse and touchpad ►] The same small right arrow icon is used in subpages, when tapping the row opens a different subpage in the same section (e.g. a "deeper" subpage). [icons-1] On the main page, a large "open-in-new" arrow indicates that tapping the row opens an external UI. For example: [Wallpaper / Open the wallpaper app [➚]] PROBLEM: What icon should be used when tapping the row navigates *to a different section*? Examples: [icons-2, icons-3] Tapping "View keyboard shortcuts" displays the native shortcut overlay. [icons-2, icons-4] Tapping "Change language settings" navigates to the main page and scrolls to the Language section. [icons-5] The "Storage management" subpage uses the small right arrow for dialogs [icons-5-1], navigable dialogs [icons-5-2], and "Other users" which navigates to a completely different section's subpage [icons-5-3].
,
Dec 14 2016
bettes@ has also mentioned that ► for UIs that help you manage Chrome are valid. he's also mentioned that [➚] is CWS and help articles. I agree that the rules are kinda blurry. but the old options page went all willy-nilly with <button> vs <a is="action-link"> vs <a href>. the separation there was: if it has a link and it's outside of the current UI, use <a href> (so you get copying of href, click disposition, etc. for free) and otherwise, if it's in the same page: if it's inline -- use an action link, else use a block <button>).
,
Dec 17 2016
> ► for UIs that help you manage Chrome are valid. > [➚] is CWS and help articles. Is it WAI to use ► for buttons that launch Chrome UI like "Report an issue"? (About page) Is it WAI for MD History to use [➚] for the button that launches the "Clear browsing data" Settings dialog? Seems inconsistent. [These questions are not rhetorical... just re-opening to ensure they're seen/answered.]
,
Dec 17 2016
another question - Cloud Print section has a
Manage Cloud Print devices [➚]
row which opens a chrome://devices/ tab
Can I propose we get a 1-2 sentence guideline, and then rename the relevant Settings icons (possibly making two icons that look the same but are semantically different) so the code looks odd when the wrong indicator is used?
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77818ddc739721826a3dc6ab741b0b2f72f023df commit 77818ddc739721826a3dc6ab741b0b2f72f023df Author: michaelpg <michaelpg@chromium.org> Date: Tue Dec 20 23:17:29 2016 Keyboard settings: icon buttons for tappable rows Add arrow button for Language settings row (which navigates to the languages section). Add external/popup button for Keyboard Shortcuts row (which opens the external CrOS keyboard shortcuts overlay). BUG= 673925 R=hcarmona@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2570743002 Cr-Commit-Position: refs/heads/master@{#439918} [modify] https://crrev.com/77818ddc739721826a3dc6ab741b0b2f72f023df/chrome/browser/resources/settings/device_page/keyboard.html
,
Dec 30 2016
Hey Michael, how's this sound: If the button opens a new tab and/or an application not owned by Chrome, use [➚] If the button helps you manage Chrome UI (either web or system), use the ► >> Tapping "View keyboard shortcuts" displays the native shortcut overlay. View keyboard shortcuts ► >> Tapping "Change language settings" navigates to the main page and scrolls to the Language section. Change language settings ► >> The "Storage management" subpage uses the small right arrow for dialogs [icons-5-1], navigable dialogs [icons-5-2], and "Other users" which navigates to a completely different section's subpage [icons-5-3]. I believe these are all correct >> Is it WAI to use ► for buttons that launch Chrome UI like "Report an issue"? (About page) Yes Is it WAI for MD History to use [➚] for the button that launches the "Clear browsing data" Settings dialog? Seems inconsistent. Inconsistent, yes. But I think the [➚] is more explanatory given the context of jumping from History > Settings. Once/if we can detach the CBD dialog from opening settings, I think we can afford to remove all indicators.
,
Dec 30 2016
Or maybe: If the button opens a new tab and/or an application not owned by Chrome, use [➚] If the button helps you manage Chrome UI AND is owned by Chrome (either web or system), use the ► There's probably going to be some room for interpretation no matter how I slice it. But for manage certs on MAC, we should use a [➚] instead of the ►. ( crbug.com/677582 )
,
Jan 7 2017
@bettes, what about saying that ► keeps you in the current window/tab (so it opens a subpage, dialog, etc), while [➚] will take you to a new tab/window? Marking as P3 since I don't think this would prevent us from launching to stable.
,
Jan 9 2017
That would require us to use "open-in-new" for the user manager on windows/Mac which is non-ideal.
,
Jan 13 2017
marking as available
,
Feb 16 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 1 2018
I am marking this as WontFix. It seems that we have settled on what is described at #8. |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by dbeam@chromium.org
, Dec 14 2016