Back in gypland, we had _run targets for producing isolates. Now that gyp is gone, we no longer need those. First, update bots to no longer build _run targets, then remove them.
https://chromium-review.googlesource.com/#/c/419296/ https://codereview.chromium.org/2569333002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/65976b6e2a612439681dc42830e90dbcdf550f40 commit 65976b6e2a612439681dc42830e90dbcdf550f40 Author: Nico Weber <thakis@chromium.org> Date: Thu Apr 20 17:57:31 2017 Remove references to gyp-only _run targets. BUG=673897 Change-Id: I7e2ec26796f1e658aff97d7d0805539481565e69 Reviewed-on: https://chromium-review.googlesource.com/419296 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Budorick <jbudorick@google.com> [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_Chromium_OS_ASan_LSan_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_GPU_TSAN_Release.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Win_Builder__ANGLE_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Win_SyzyAsan__rel_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_GPU_ASAN_Release.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_ASAN.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Win_Release__NVIDIA_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win_x64_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/swarming/staging.expected/one_fails.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Win_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Fake_Linux_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_perf_Linux_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ChromiumOS_MSan_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/master/factory/commands.py [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/test_without_targets_not_skipped.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Builder_FYI.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_MSAN.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_v8_chromium_Linux___Future__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder_Trybot.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Linux_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_Release__NVIDIA_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Mac_Release__Intel_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_MSan_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Win.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_remote_run_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Win_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mojo_ChromiumOS.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux_layout_ng_Dummy_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_swarm_Windows_Swarm.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_swarm_Mac_Swarm.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux_slimming_paint_v2_Dummy_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_swarm_Linux_Swarm.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_memory_Mac_ASan_64_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mojo_Windows.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Mac___RandomOrder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___RandomOrder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipe_modules/chromium_tests/steps.py [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Win___RandomOrder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_LSan_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Browser_Side_Navigation_Linux.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Clang_Analyzer.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_x64_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Mac_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_v8_chromium_Linux___Future.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win_x64_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Linux_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_x64_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Mac_Builder__dbg_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_ARM.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsanCov.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder_Trybot.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_TSan_Builder.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Linux.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_dll_.json [modify] https://crrev.com/65976b6e2a612439681dc42830e90dbcdf550f40/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty_Leak.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/92c5b81e16d2f32004f33b82930500507faee868 commit 92c5b81e16d2f32004f33b82930500507faee868 Author: Nico Weber <thakis@chromium.org> Date: Thu Apr 20 20:43:08 2017 Try to fix Google Chrome Linux(x64) builder. See https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/JV3wzWYCLlw Bug: 673897 Change-Id: I84f0447a8c49462472e5bd42676c59b0d37e8471 TBR=dpranke Reviewed-on: https://chromium-review.googlesource.com/483683 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> [modify] https://crrev.com/92c5b81e16d2f32004f33b82930500507faee868/scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py [modify] https://crrev.com/92c5b81e16d2f32004f33b82930500507faee868/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d66d232a08315927b4ffb6212c1516c6ddfbe6d commit 1d66d232a08315927b4ffb6212c1516c6ddfbe6d Author: thakis <thakis@chromium.org> Date: Thu Apr 20 21:58:55 2017 Address some TODO(GYP_GONE)s No intended behavior change. If this breaks your bot because it's trying to build a foo_run target, make it build the corresponding foo target instead (see diff). Depends on https://chromium-review.googlesource.com/#/c/419296/ BUG=673897 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=brettw Review-Url: https://codereview.chromium.org/2569333002 Cr-Commit-Position: refs/heads/master@{#466154} [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/breakpad/BUILD.gn [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/chrome/installer/linux/BUILD.gn [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/chrome/test/BUILD.gn [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/sandbox/linux/BUILD.gn [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.android.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.linux.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.mac.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/chromium.win.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/buildbot/client.v8.fyi.json [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/testing/test.gni [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/ui/gl/BUILD.gn [modify] https://crrev.com/1d66d232a08315927b4ffb6212c1516c6ddfbe6d/ui/vector_icons/aggregate_vector_icons.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/637c7353077c92bbf627b602c57f0e3604525129 commit 637c7353077c92bbf627b602c57f0e3604525129 Author: sgurun <sgurun@chromium.org> Date: Thu Apr 20 23:00:27 2017 Revert of Address some TODO(GYP_GONE)s (patchset #6 id:100001 of https://codereview.chromium.org/2569333002/ ) Reason for revert: breaking android builder, see crbug.com/713915 Original issue's description: > Address some TODO(GYP_GONE)s > > No intended behavior change. If this breaks your bot because it's > trying to build a foo_run target, make it build the corresponding > foo target instead (see diff). > > Depends on https://chromium-review.googlesource.com/#/c/419296/ > > BUG=673897 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=brettw > > Review-Url: https://codereview.chromium.org/2569333002 > Cr-Commit-Position: refs/heads/master@{#466154} > Committed: https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1516c6ddfbe6d TBR=dpranke@chromium.org,kbr@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673897 Review-Url: https://codereview.chromium.org/2831243002 Cr-Commit-Position: refs/heads/master@{#466177} [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/breakpad/BUILD.gn [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/chrome/installer/linux/BUILD.gn [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/chrome/test/BUILD.gn [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/sandbox/linux/BUILD.gn [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.android.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.linux.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.mac.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/chromium.win.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/buildbot/client.v8.fyi.json [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/testing/test.gni [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/ui/gl/BUILD.gn [modify] https://crrev.com/637c7353077c92bbf627b602c57f0e3604525129/ui/vector_icons/aggregate_vector_icons.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cb3b1d088bdd435de0292a58966c4c514acd0a1 commit 9cb3b1d088bdd435de0292a58966c4c514acd0a1 Author: thakis <thakis@chromium.org> Date: Fri Apr 21 14:48:55 2017 Address some TODO(GYP_GONE)s No intended behavior change. If this breaks your bot because it's trying to build a foo_run target, make it build the corresponding foo target instead (see diff). Depends on https://chromium-review.googlesource.com/#/c/419296/ BUG=673897 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=brettw Review-Url: https://codereview.chromium.org/2569333002 Cr-Original-Commit-Position: refs/heads/master@{#466154} Committed: https://chromium.googlesource.com/chromium/src/+/1d66d232a08315927b4ffb6212c1516c6ddfbe6d Review-Url: https://codereview.chromium.org/2569333002 Cr-Commit-Position: refs/heads/master@{#466331} [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/breakpad/BUILD.gn [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/chrome/installer/linux/BUILD.gn [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/chrome/test/BUILD.gn [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/sandbox/linux/BUILD.gn [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.android.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.linux.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.mac.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/chromium.win.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/buildbot/client.v8.fyi.json [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/testing/test.gni [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/ui/gl/BUILD.gn [modify] https://crrev.com/9cb3b1d088bdd435de0292a58966c4c514acd0a1/ui/vector_icons/aggregate_vector_icons.py
Comment 1 by thakis@chromium.org
, Dec 13 2016