New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673894 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: hide expansion arrow when console trace has no stack

Project Member Reported by l...@chromium.org, Dec 13 2016

Issue description

- Open DevTools Sources panel and make sure 'Async' is unchecked
- Enter "setTimeout(')', 0)" into the console
- Expand the arrow in the error message

Actual: The error message has an arrow that reveals nothing when clicked
Expected: Don't show the arrow at all when there is no stack to reveal
 

Comment 1 by l...@chromium.org, Aug 14 2017

Cc: l...@chromium.org
 Issue 684646  has been merged into this issue.

Comment 2 by l...@chromium.org, Aug 14 2017

 Issue 740188  has been merged into this issue.

Comment 3 by l...@chromium.org, Aug 14 2017

Also consider these examples that should not need an arrow:
console.dir() a primitive value

For example:
console.dir(123)
console.dir(null)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f143fbb38d2ffc5f300306c956934645a7cfad

commit 95f143fbb38d2ffc5f300306c956934645a7cfad
Author: Erik Luo <luoe@chromium.org>
Date: Wed Aug 23 04:02:41 2017

DevTools: do not show expand arrow for objects without props

Object-type objects in the console always format as an
ObjectPropertiesSection with an expansion arrow. This CL removes the
unnecessary expansion arrow for objects that have no properties.

Screenshot: http://imgur.com/a/Iiwu9

Bug:  673894 
Change-Id: Ic82cb745ee2f564ed51dccb03607e57449a83c8d
Reviewed-on: https://chromium-review.googlesource.com/624464
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496582}
[add] https://crrev.com/95f143fbb38d2ffc5f300306c956934645a7cfad/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-primitives-expected.txt
[add] https://crrev.com/95f143fbb38d2ffc5f300306c956934645a7cfad/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-primitives.js
[modify] https://crrev.com/95f143fbb38d2ffc5f300306c956934645a7cfad/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Comment 5 by l...@chromium.org, Aug 23 2017

Status: Fixed (was: Assigned)

Sign in to add a comment