New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673893 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Dec 2016
Cc:
█ kbr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

gpu conformance presubmit fails for me

Project Member Reported by thakis@chromium.org, Dec 13 2016 
I made a change touching content/test/...gpu. Now `git cl upload` prints screenfuls of stuff looking like

[26/45] gpu_tests.webgl_conformance_expectations_unittest.WebGLConformanceExpectationsTest.testWebGL2ExpectationsHaveNoCollisions failed unexpectedly 0.0020s:
  Traceback (most recent call last):
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py", line 80, in testWebGL2ExpectationsHaveNoCollisions
      webgl_conformance_integration_test.conformance_path)
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py", line 11, in __init__
      conformance_path, url_prefixes=url_prefixes)
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/webgl_conformance_expectations.py", line 14, in __init__
      url_prefixes=url_prefixes)
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/gpu_test_expectations.py", line 80, in __init__
      super(GpuTestExpectations, self).__init__(url_prefixes=url_prefixes)
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/test_expectations.py", line 105, in __init__
      self.SetExpectations()
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py", line 48, in SetExpectations
      bug=660844) # WebGL 2.0.1
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/webgl_conformance_expectations.py", line 17, in Fail
      self.CheckPatternIsValid(pattern)
    File "/usr/local/google/home/thakis/src/chrome/src/content/test/gpu/gpu_tests/webgl_conformance_expectations.py", line 35, in CheckPatternIsValid
      'expectation does not exist: ' + full_path)
  Exception: The WebGL conformance test path specified in expectation does not exist: /usr/local/google/home/thakis/src/chrome/src/third_party/webgl/src/sdk/tests/conformance2/rendering/depth-stencil-feedback-loop.html



It's not clear to me if my patch broke something of if this code is just broken. I'll --bypass-hooks.

Comment 1 by thakis@chromium.org, Dec 13 2016 

  
[43/45] gpu_tests.gpu_test_base_unittest.PageExecutionTest.testFlakyPageThenPassingPage passed 0.1624s:
  FLAKY TEST FAILURE, retrying: page1
  [host]> /usr/local/google/home/thakis/src/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
  [host]> /usr/local/google/home/thakis/src/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
  [host]> /usr/local/google/home/thakis/src/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
  [host]> /usr/local/google/home/thakis/src/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
  [host]> /usr/local/google/home/thakis/src/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
[44/45] gpu_tests.lint_unittest.LintTest.testPassingPylintCheckForPageSetsDir passed 1.2848s
[45/45] gpu_tests.lint_unittest.LintTest.testPassingPylintCheckForGpuTestsDir passed 7.9309s
45 tests run in 8.3s, 3 failures.





Why does this folder run tests (!) as part of presubmit?

Comment 2 by kbr@chromium.org, Dec 14 2016

Status: WontFix (was: Untriaged)
#0: your workspace is out of date and third_party/webgl/src/ is an older version that's missing some of the path names referenced in webgl[2]_conformance_expectations.py . You need to run "gclient sync".

#1: it runs some tests because otherwise those would only run on the trybots, leading to a much longer cycle time to learn that you'd misspelled the path to a test file you'd intended to suppress.

The fact that Telemetry's trying to talk to your phone is a pain and one which I've worked around by unplugging my phone from my Linux desktop unless I'm actively debugging it. Feel free to file that under Tests>Telemetry.
►

Sign in to add a comment