I'll take care of CriteriaHelper while I'm sheriffing today/tomorrow

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ff981acebe329c1e8ac43c21970c3e70044b04

commit 98ff981acebe329c1e8ac43c21970c3e70044b04
Author: twellington <twellington@chromium.org>
Date: Thu Dec 15 19:27:39 2016

Catch InterruptedException in CriteriaHelper

Catch the InterruptedException in CriteriaHelper#* and remove
the throws declaration from methods that no longer need to
declare it.

BUG=673892
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2573263002
Cr-Commit-Position: refs/heads/master@{#438892}

[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/FocusedEditableTextFieldZoomTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/HistoryUITest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/overlays/strip/TabStripTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTestBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapterTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtilsTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationTestBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerDisableIncognitoModeIntegrationTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageIntegrationTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivityTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelMergingTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/AutofillTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ActivityUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/FullscreenTestUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/NewTabPageTestUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OmniboxTestUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OverviewModeBehaviorWatcher.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/TabStripUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/contextmenu/ContextMenuUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/ApplicationUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CriteriaHelper.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java
[modify] https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

wychen: Did this get better when you update the criteria stuff to support lambdas?

Methods in CriteriaHelper no longer throw exceptions after https://codereview.chromium.org/2573263002 in #c2. Looks like CriteriaHelper is already fixed. My change was orthogonal to this issue, so it didn't help.

CallbackHelper#waitForCallback() still needs work though.

Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.