New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673852 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Continuously keep IDL files in sync with the specs they link to

Project Member Reported by foolip@chromium.org, Dec 13 2016

Issue description

Objective: develop tooling to scrape the specs that are linked from Blink's IDL files, and make it easy to find the things that are different.

This is the successor for  issue 460722 , where roughly 50% of Blink's IDL files were manual synced with their specs and annotated with TODOs. This revealed lots of problem to fix, and many were fixed, but even if completed it would be hard to know when we diverge again.

As part of this issue, certain categories of problems will be identified, like "missing constructor" or "argument has the wrong type", and some of the less risky ones will be fixed.
 

Comment 1 by foolip@chromium.org, Dec 13 2016

Blockedon: 673664 673698
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/735266cdacea9f085c7b4b864cfa6658517f3845

commit 735266cdacea9f085c7b4b864cfa6658517f3845
Author: foolip <foolip@chromium.org>
Date: Tue Dec 13 23:08:00 2016

Replace remaining /TR/ links in SVG IDL

In order to get rid of the second link in SVGSVGElement, sync the order
with the specs. (But don't include the "deprecated" comment since
deprecation means something different in Blink.)

BUG=673852

Review-Url: https://codereview.chromium.org/2572853002
Cr-Commit-Position: refs/heads/master@{#438325}

[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGClipPathElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGComponentTransferFunctionElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEBlendElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFECompositeElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEDistantLightElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEFloodElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEFuncAElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEFuncBElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEFuncGElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEFuncRElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEImageElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEMergeElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEMergeNodeElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEOffsetElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFEPointLightElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFESpotLightElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFETileElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFilterElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGMaskElement.idl
[modify] https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845/third_party/WebKit/Source/core/svg/SVGSVGElement.idl

Comment 3 by foolip@chromium.org, Dec 14 2016

Blockedon: 662005

Comment 4 by lunalu@chromium.org, Dec 14 2016

Blocking: 662005

Comment 5 by lunalu@chromium.org, Dec 14 2016

Blocking: -662005
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d47b367e0a84c0c1f9f028ce2c865518e06db632

commit d47b367e0a84c0c1f9f028ce2c865518e06db632
Author: foolip <foolip@chromium.org>
Date: Wed Dec 14 13:27:35 2016

Update stale links to dvcs.w3.org

Most links redirected to the right location, some were found manually.

In IDL files, links remain in modules/mediasource/TrackDefault.idl which
is gone from the spec and modules/speech/*.idl, which is still
maintained at dvcs.w3.org

BUG=673852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2573043002
Cr-Commit-Position: refs/heads/master@{#438500}

[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/dom/Document.idl
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/dom/Range.idl
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/dom/TagCollection.cpp
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/events/MouseEvent.idl
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/events/MouseEventInit.idl
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/html/HTMLTagCollection.h
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.idl
[modify] https://crrev.com/d47b367e0a84c0c1f9f028ce2c865518e06db632/third_party/WebKit/Source/modules/mediasource/URLMediaSource.idl

Comment 7 by foolip@chromium.org, Dec 15 2016

Blockedon: 674507

Comment 8 by foolip@chromium.org, Dec 15 2016

Blockedon: 561338
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd514c7dc9f0f3c9e282eed61d8adc9d2c84698

commit 0dd514c7dc9f0f3c9e282eed61d8adc9d2c84698
Author: markdittmer <markdittmer@chromium.org>
Date: Thu Dec 15 15:24:51 2016

Fix old link to navidz to now refer to wicg

BUG=673852
NOTRY=true

Review-Url: https://codereview.chromium.org/2584583002
Cr-Commit-Position: refs/heads/master@{#438831}

[modify] https://crrev.com/0dd514c7dc9f0f3c9e282eed61d8adc9d2c84698/third_party/WebKit/Source/core/dom/GlobalEventHandlers.idl

Blockedon: 674593
I've filed issue 674593 to triage non-standard parts of our IDL.
Blockedon: 497307
Blocking: 304959
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7205b398e80becc61caca85c372f7c751940d3b

commit d7205b398e80becc61caca85c372f7c751940d3b
Author: foolip <foolip@chromium.org>
Date: Fri Apr 14 18:21:08 2017

Replace most /TR/ links in IDL files

Almost all remaining /TR/ links are problematic in some way, typically
being unmaintained specs with no easy way of making changes.

BUG=673852

Review-Url: https://codereview.chromium.org/2824463002
Cr-Commit-Position: refs/heads/master@{#464755}

[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/animation/AnimationTimeline.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/animation/DocumentTimeline.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/animation/ElementAnimation.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/css/CSSFontFaceRule.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/css/StyleMedia.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/dom/Document.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/dom/FrameRequestCallback.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/events/InputEvent.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/events/InputEventInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/events/TextEvent.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/svg/SVGMaskElement.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/svg/SVGMatrix.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/svg/SVGPatternElement.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/svg/SVGPoint.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/core/svg/SVGRect.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/crypto/SubtleCrypto.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_light/DeviceLightEvent.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_light/DeviceLightEventInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_orientation/DeviceAccelerationInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEventInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/device_orientation/DeviceRotationRateInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBCursorWithValue.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBIndexParameters.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBKeyRange.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStoreParameters.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBVersionChangeEvent.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/indexeddb/IDBVersionChangeEventInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/mediasource/MediaSource.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/peerconnection/RTCDTMFToneChangeEvent.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/peerconnection/RTCDTMFToneChangeEventInit.idl
[modify] https://crrev.com/d7205b398e80becc61caca85c372f7c751940d3b/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidateInit.idl

Blocking: -304959
Blockedon: 304959
Cc: -lunalu@chromium.org loonyb...@chromium.org

Sign in to add a comment