New issue
Advanced search Search tips

Issue 673851 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

SkCanvas clipping only (wants to support) Intersect and Difference

Project Member Reported by reed@google.com, Dec 13 2016

Issue description

... any other "op" may expand the clip, which is problematic for ganesh (and other backends like PDF).

kReplace is used in one place in software_renderer. Can we restructure that to use save/restore/intersect_or_difference?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717

commit c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717
Author: reed <reed@google.com>
Date: Wed Dec 14 00:21:17 2016

stop using exotic clipops

The only caller of an "exotic" is in software_renderer, and that one is preserved (with a scary enum name to remind us to fix it). All the other changes are purely mechanical .. remove cases from translation tables.

The remaining case will be addressed in a separate CL, using this bug.

BUG=673851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=

Review-Url: https://codereview.chromium.org/2572833002
Cr-Commit-Position: refs/heads/master@{#438355}

[modify] https://crrev.com/c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717/cc/output/software_renderer.cc
[modify] https://crrev.com/c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717/cc/playback/display_item_list_unittest.cc
[modify] https://crrev.com/c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717/cc/proto/skia_conversions.cc
[modify] https://crrev.com/c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717/cc/proto/skia_conversions_unittest.cc
[modify] https://crrev.com/c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717/skia/config/SkUserConfig.h
[modify] https://crrev.com/c247ca2c76ca4f08cbac9ef99b0ad1179ba8a717/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

Status: Assigned (was: Untriaged)

Sign in to add a comment