New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673850 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Webkit font tests are failing on Linux Trusty (dbg) & Mac10.11 (dbg)

Project Member Reported by nedngu...@google.com, Dec 13 2016

Issue description

Failing tests are:

http/tests/webfont/font-display-intervention.html 
http/tests/webfont/font-display.html 
virtual/mojo-loading/http/tests/webfont/font-display-intervention.html 
virtual/mojo-loading/http/tests/webfont/font-display.html 


Suspecting https://codereview.chromium.org/2557533005
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14e73349c627e9e861263bd069d63ac7df9c3147

commit 14e73349c627e9e861263bd069d63ac7df9c3147
Author: paulmeyer <paulmeyer@chromium.org>
Date: Tue Dec 13 20:54:32 2016

Revert of Collect active stylesheets and and apply asynchronously. (patchset #4 id:60001 of https://codereview.chromium.org/2557533005/ )

Reason for revert:
Suspected cause of failing WebKit tests on bots. Example: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6390

BUG= 673850 

Original issue's description:
> Collect active stylesheets and and apply asynchronously.
>
> This CL enables asynchronously updating the lists of active stylesheets
> applying any style changes using rule set invalidations. This means we
> more often avoid full style recalcs when we add or remove stylesheets
> from the document as well as when the evaluation of media queries
> change.
>
> In general, we now alway compare new and old stylesheets by comparing
> their rulesets and schedule style invalidations for removed and added
> rulesets.
>
> When media queries changes, we used to give completely in and
> recalculate all style once we discovered a media query changed its
> evaluation. With this patch, we clear rule sets for sheets which
> contain media queries which means we will invalidate rules for the sets
> before and after the query change. This can be further refined by only
> clearing rule sets when the sheets has a media query which actually did
> change evaluation, and also just schedule invalidations for rules which
> are inside @media rules.
>
> TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
> ActiveStyleSheetsTest.cpp which landed earlier.
>
> updateActiveStyle() has been added a few places where
> ensureStyleResolver() previously caused active stylesheets to be up-to-
> date. ensureStyleResolver() is now merely a method which creates the
> StyleResolver if necessary and returns it.
>
> There are some cleanups and code removal which needs to be done after
> this CL, but I have left those out to make this CL as small as
> possible. For instance resolverChanged(), which synchronously updated
> the active stylesheets, has an empty implementation instead of
> including a lot of removals in this CL. The code for lazy-appending
> stylesheets in StyleResolver is still there, but not in use.
>
> R=meade@chromium.org
> BUG= 567021 
>
> Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
> Cr-Commit-Position: refs/heads/master@{#438148}

TBR=esprehn@chromium.org,meade@chromium.org,sashab@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 567021 

Review-Url: https://codereview.chromium.org/2572473006
Cr-Commit-Position: refs/heads/master@{#438278}

[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/LayoutTests/animations/add-keyframes-in-shadow-recalc.html
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style-expected.txt
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.h
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollector.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollector.h
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.h
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/StyleEngine.h
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/StyleSheetCollection.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/StyleSheetCollection.h
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h
[add] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollectionTest.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Comment 2 by tkent@chromium.org, Dec 19 2016

Components: Blink>WebFonts
Owner: r...@opera.com
Status: Fixed (was: Untriaged)
Fixed by https://codereview.chromium.org/2584473002/.

Sign in to add a comment