New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673841 link

Starred by 1 user
Status: Duplicate
Merged: issue 649050
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
dbeam@chromium.org
mac-bugs-priority@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Server spellcheck setting should show a privacy warning

Project Member Reported by rouslan@chromium.org, Dec 13 2016 
Chrome Version: 57.0.2946.0 (Official Build) dev (64-bit)
OS: macOS Sierra Version 10.12.1

What steps will reproduce the problem?
(1) Open chrome://settings/
(2) Turn on "Use a web service to help resolve spelling errors" option.

What is the expected result?
A privacy warning message should appear. The user must click "Agree" to enable server-side spellcheck.

What happens instead?
No privacy warning message appears.

Please use labels and text to provide additional information.
This is for MD settings. Have not tested on other platforms.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by groby@chromium.org, Dec 13 2016

Labels: -Pri-2 Pri-1
See here for the relevant code to show the bubble: https://cs.chromium.org/chromium/src/chrome/browser/renderer_context_menu/spelling_menu_observer.cc?sq=package:chromium&dr=C&rcl=1481631594&l=283

P1 due to privacy implications.

Comment 2 by dbeam@chromium.org, Dec 14 2016

Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
dschuyler@: hasn't this already been addressed fairly recently?

Comment 3 by dschuyler@chromium.org, Dec 14 2016

Mergedinto: 649050
Status: Duplicate (was: Assigned)
@dbeam, yes. Instead of putting up a dialog a two line label is used on the control. The secondary line explains what the dialog would explain.

I have the approval email from senior counsel to use the secondary line instead of the dialog (please let me know if you'd like me to forward it to you).

Comment 4 by rouslan@chromium.org, Dec 14 2016 

Please forward it to groby@, rouslan@, and krb@. Thank you!

Comment 5 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck
►

Sign in to add a comment