event_mon.checkouts should be either fixed or removed. |
||||||
Issue description
[I2016-12-13T00:01:06.934690-08:00 32518 140024727476032 __main__:251] CQ starting
[D2016-12-13T00:01:06.942366-08:00 32518 140024727476032 infra_libs.event_mon.checkouts:67] Running: /b/infra_internal/ENV/lib/python2.7/depot_tools/gclient revinfo -a
[E2016-12-13T00:01:06.948322-08:00 32518 140024727476032 infra_libs.event_mon.checkouts:72] Command failed to run: /b/infra_internal/ENV/lib/python2.7/depot_tools/gclient revinfo -a
Traceback (most recent call last):
File "/b/infra_internal/ENV/local/lib/python2.7/site-packages/infra_libs/event_mon/checkouts.py", line 70, in get_revinfo
revinfo = subprocess.check_output(cmd, cwd=cwd)
File "/usr/lib/python2.7/subprocess.py", line 566, in check_output
process = Popen(stdout=PIPE, *popenargs, **kwargs)
File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
[D2016-12-13T00:01:06.952005-08:00 32518 140024727476032 infra_libs.event_mon.router:235] event_mon: POSTing events to https://play.googleapis.com/log
,
Dec 13 2016
The reason: http://go/chromerev/176947013 solving issue 468453 . I'm not sure if we actually use this information.
,
Dec 13 2016
Thanks! I've not used that info, that it could be useful. So, apparently something is wrong with path in which gclient is run.
,
Dec 13 2016
err, the error is because of where depot_tools is loaded from: /b/infra_internal/ENV/lib/python2.7/depot_tools/gclient is clearly wrong.
,
Dec 13 2016
I think the cwd is actually "more wrong". CL to fix this: https://chrome-internal-review.googlesource.com/311716
,
Dec 13 2016
,
Dec 13 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/ec8aae91e931c307558a076b7ee6ac84df7001f2 commit ec8aae91e931c307558a076b7ee6ac84df7001f2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Dec 13 20:45:40 2016
,
Dec 16 2016
They are both wrong.
,
Dec 16 2016
Wow, event_mon code smells:
BASE_DIR = os.path.dirname(
os.path.dirname(
os.path.dirname(
os.path.dirname(os.path.realpath(__file__)))))
cmd = [os.path.join(BASE_DIR, 'depot_tools', 'gclient'), 'revinfo', '-a']
see for yourself: https://cs.chromium.org/chromium/infra/packages/infra_libs/infra_libs/event_mon/checkouts.py?q=event_mon+checkouts.py&sq=package:chromium&dr&l=65
I'm removing this from CQ completely.
,
Dec 19 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/744e6771a5af53461cea7af5e834912685587ff5 commit 744e6771a5af53461cea7af5e834912685587ff5 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Dec 16 17:08:07 2016
,
Jan 5 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/94873aff310a1e83e10d417e577f98b1c399f2f7 commit 94873aff310a1e83e10d417e577f98b1c399f2f7 Author: Sergey Berezin <sergeyberezin@google.com> Date: Thu Jan 05 23:07:03 2017
,
Jan 6 2017
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/f91b16836aafeac59ec26a24406f6b794a29526b commit f91b16836aafeac59ec26a24406f6b794a29526b Author: Sergey Berezin <sergeyberezin@google.com> Date: Fri Jan 06 00:15:16 2017 event_mon: remove get_revinfo and gclient reference Previously, event_mon assumed depot_tools checkout at a particular location relative to its own installation. Now that infra_libs is a stand-alone Python package, this assumption is no longer true. BUG= 673839 R=tandrii@chromium.org Change-Id: I1538cbc4885b4d5669fd710f6aa5f433c9cb6491 Reviewed-on: https://chromium-review.googlesource.com/425445 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> [modify] https://crrev.com/f91b16836aafeac59ec26a24406f6b794a29526b/appengine_module/gae_event_mon/__init__.py [modify] https://crrev.com/f91b16836aafeac59ec26a24406f6b794a29526b/infra/tools/send_monitoring_event/common.py [modify] https://crrev.com/f91b16836aafeac59ec26a24406f6b794a29526b/infra/tools/send_monitoring_event/test/common_test.py [modify] https://crrev.com/f91b16836aafeac59ec26a24406f6b794a29526b/packages/infra_libs/infra_libs/event_mon/__init__.py [modify] https://crrev.com/f91b16836aafeac59ec26a24406f6b794a29526b/packages/infra_libs/infra_libs/event_mon/checkouts.py
,
Sep 19 2017
This is now obsoleted by issue 615218. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tandrii@chromium.org
, Dec 13 2016