It's now synonymous with OS_CHROMEOS, so we should just use OS_CHROMEOS.
BUILD flag use_ash should probably be replaced with is_chromeos as well.
sky, do you still think this is worth doing? I could imagine keeping USE_ASH if we thought we might build Chrome for Chrome OS without ash someday.
I'm not aware of any such plans. Additionally I can't imagine USE_ASH actually works on other platforms at this point without a bunch of changes. We should remove USE_ASH. It'll force more cleanup and make it obvious that there is only OS_CHROMEOS.
Also, this allows us to remove a bunch of // nogncheck, and consolidate some strange ifdef blocks. I'll draft a CL.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9d34d23b29effc1aacc57463cabe47f30dc08b3 commit f9d34d23b29effc1aacc57463cabe47f30dc08b3 Author: James Cook <jamescook@chromium.org> Date: Wed Oct 04 16:39:35 2017 Eliminate USE_ASH macro and replace with OS_CHROMEOS We have not shipped Windows Ash for years. There is a 1:1 mapping between USE_ASH and OS_CHROMEOS, so consolidate them. The BUILD.gn files will be cleaned up separately. Bug: 673826 Test: compiles, gn check on Chrome OS, Linux and Linux Ozone Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5ebf64a133d1032f0d7864ed1a180d0f0b170da1 Reviewed-on: https://chromium-review.googlesource.com/692699 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506410} [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/build/config/BUILD.gn [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/build/config/ui.gni [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/about_flags.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/apps/app_browsertest.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/browser_keyevents_browsertest.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/chrome_notification_types.h [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/extensions/launch_util.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/extensions/window_open_apitest.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/flag_descriptions.h [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/fullscreen.h [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/lifetime/application_lifetime_aura.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/signin/signin_global_error_factory.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/app_list/app_list_util.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/apps/chrome_app_delegate.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/bookmarks/bookmark_utils.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/toolbar/app_menu_model.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/accelerator_table.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/accelerator_table_unittest.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/accelerator_utils_aura.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/chrome_web_dialog_view.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/harmony/chrome_typography.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/harmony/chrome_typography.h [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/screen_capture_notification_ui_views.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/task_manager_view.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/window_sizer/window_sizer.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/browser/ui/window_sizer/window_sizer.h [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/test/base/chrome_render_view_host_test_harness.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/chrome/test/base/interactive_test_utils_win.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/remoting/host/chromeos/aura_desktop_capturer.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/ui/gl/sync_control_vsync_provider.cc [modify] https://crrev.com/f9d34d23b29effc1aacc57463cabe47f30dc08b3/ui/views/accessible_pane_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/166d47a479109b0113c418b133c148e801174ff1 commit 166d47a479109b0113c418b133c148e801174ff1 Author: James Cook <jamescook@chromium.org> Date: Wed Oct 04 20:53:33 2017 Remove use_ash from resource grd files We have not shipped Windows Ash for years. There is a 1:1 mapping between "use_ash" and "chromeos", so consolidate them. TBR=oshima@chromium.org for theme_resources.grd Bug: 673826 Test: compiles, bots Change-Id: If76122c1089cde2ec2b7d8822a4ca0adde25e5f3 Reviewed-on: https://chromium-review.googlesource.com/699663 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506508} [modify] https://crrev.com/166d47a479109b0113c418b133c148e801174ff1/chrome/app/generated_resources.grd [modify] https://crrev.com/166d47a479109b0113c418b133c148e801174ff1/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/166d47a479109b0113c418b133c148e801174ff1/tools/grit/grit_rule.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42fbcd4a7deb7e4f5357217686c70658c7aa87f2 commit 42fbcd4a7deb7e4f5357217686c70658c7aa87f2 Author: James Cook <jamescook@chromium.org> Date: Thu Oct 05 19:53:06 2017 Remove use_ash from BUILD.gn in //chrome/browser We have not shipped Windows Ash for years. There is a 1:1 mapping between use_ash and is_chromeos, so consolidate them. Bug: 673826 Test: compiles, gn check for Chrome OS, Linux, Linux Ozone Change-Id: Idc459cbca6b8447ce0f7e7aa9772e38835492234 Reviewed-on: https://chromium-review.googlesource.com/702756 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506835} [modify] https://crrev.com/42fbcd4a7deb7e4f5357217686c70658c7aa87f2/chrome/browser/BUILD.gn [modify] https://crrev.com/42fbcd4a7deb7e4f5357217686c70658c7aa87f2/chrome/browser/extensions/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa9b7d70064eac995fdb6ef1a1f3c953af675dd commit 7fa9b7d70064eac995fdb6ef1a1f3c953af675dd Author: James Cook <jamescook@chromium.org> Date: Thu Oct 05 21:23:13 2017 Remove use_ash from BUILD.gn in //chrome/browser/ui We have not shipped Windows Ash for years. There is a 1:1 mapping between use_ash and is_chromeos, so consolidate them. Bug: 673826 Test: compiles, gn check for Chrome OS, Linux, Linux Ozone Change-Id: Ibdb2f52c19e3d49aa4742b58775013c425adff22 Reviewed-on: https://chromium-review.googlesource.com/702916 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506863} [modify] https://crrev.com/7fa9b7d70064eac995fdb6ef1a1f3c953af675dd/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/7fa9b7d70064eac995fdb6ef1a1f3c953af675dd/chrome/browser/ui/views/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cceec1268d60f1fa986301722efcf99bb2ebb9f commit 1cceec1268d60f1fa986301722efcf99bb2ebb9f Author: James Cook <jamescook@chromium.org> Date: Thu Oct 05 22:13:39 2017 Remove !is_chromecast condition from use_ash Part of the cleanup of use_ash. This is left over from the days when use_ash was true for is_linux, so chromecast needed to explicitly disable use_ash. Bug: 673826 Change-Id: I9f2613a1e1bf636d0dc69ab1341fdfd75b279414 Reviewed-on: https://chromium-review.googlesource.com/692709 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Stephen Lanham <slan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506878} [modify] https://crrev.com/1cceec1268d60f1fa986301722efcf99bb2ebb9f/build/config/ui.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55771bb115813469e134f0f782528986deec8192 commit 55771bb115813469e134f0f782528986deec8192 Author: James Cook <jamescook@chromium.org> Date: Wed Oct 11 17:25:52 2017 Remove use_ash from BUILD.gn in //remoting We have not shipped Windows Ash for years. There is a 1:1 mapping between use_ash and is_chromeos, so consolidate them. TBR=kelvinp@chromium.org Bug: 673826 Test: compiles, gn check for Chrome OS, Linux, Linux Ozone Change-Id: I7d7bafe223811dbc8d2a94b96840dbac7b45eef3 Reviewed-on: https://chromium-review.googlesource.com/702656 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#508014} [modify] https://crrev.com/55771bb115813469e134f0f782528986deec8192/remoting/host/BUILD.gn [modify] https://crrev.com/55771bb115813469e134f0f782528986deec8192/remoting/host/chromeos/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ff75a4a640c484375707ad696797c87043014a commit 50ff75a4a640c484375707ad696797c87043014a Author: James Cook <jamescook@chromium.org> Date: Wed Oct 11 17:30:20 2017 Remove use_ash from chrome/test/BUILD.gn We have not shipped Windows Ash for years. There is a 1:1 mapping between use_ash and is_chromeos, so consolidate them. Bug: 673826 Test: compiles, gn check for Chrome OS, Linux, Linux Ozone Change-Id: I68d721a868b393686aa29a60895ac21e8ae79377 Reviewed-on: https://chromium-review.googlesource.com/707788 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#508015} [modify] https://crrev.com/50ff75a4a640c484375707ad696797c87043014a/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c commit f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c Author: James Cook <jamescook@chromium.org> Date: Mon Oct 16 18:51:39 2017 Eliminate use_ash build flag We have not shipped Windows Ash for years. There is a 1:1 mapping between use_ash and is_chromeos, so consolidate them. Bug: 673826 Test: compiles, gn check for Chrome OS, Linux, Linux Ozone Change-Id: I00eddfc301716dec6e8468b2df42cdbd528829a5 Reviewed-on: https://chromium-review.googlesource.com/719455 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#509121} [modify] https://crrev.com/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c/BUILD.gn [modify] https://crrev.com/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c/build/args/headless.gn [modify] https://crrev.com/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c/build/config/ui.gni [modify] https://crrev.com/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c/chrome/chrome_paks.gni [modify] https://crrev.com/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c/chrome/chrome_repack_locales.gni [modify] https://crrev.com/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c/mash/common/BUILD.gn [modify] https://crrev.com/f8a2bf756a2b3d3e9ee1f447e1c2d94157a4e69c/tools/mb/mb_config.pyl
Done!
Comment 1 by jamescook@chromium.org
, Dec 13 2016