New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673825 link

Starred by 9 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Feb 2017
Cc:
fukino@chromium.org
█ imch...@chromium.org
█ groby@chromium.org
dbeam@chromium.org
█ dfreedm@chromium.org
dpranke@chromium.org
█ tsergeant@chromium.org
█ nduca@chromium.org
michae...@chromium.org
thakis@chromium.org
█ ajo@google.com
█ brettw@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 691965
issue 693619
Blocking:
issue 597347



Sign in to add a comment

WebUI: Integrate Vulcanize to GN/Ninja

Project Member Reported by dpa...@chromium.org, Dec 13 2016 
Because we are not integrated with GN yet, we are forced to:

 - Manually run the script locally when a change is made.
 - Check in generated code
 - White-list generated code from linter presubmit scripts (since generated code violates style).
 - Ignore unhelpful results in code search/grep

A more viable approach is to only check in source code in the repository and generate the JS/HTML bundles at compile time, based on the target platform and other grit variables.


I have managed to get the overall workflow working for MD Downloads and MD Settings. There are quite a few subtasks to get resolved before all the necessary pieces are  in place, so this bug will serve as a tracking bug for all such subtasks.


Current progress:
1) https://codereview.chromium.org/2569283002: Adds GN rules for vulcanize.
2) https://codereview.chromium.org/2569293002: Vulcanize MD Downloads at compile time
3) https://codereview.chromium.org/2573943002: Vulcanize MD Settings at compile time.

Part of this work was originally done by michaelpg at https://codereview.chromium.org/2513673005/.

I will follow up on this bug about subtasks that need to be addressed.

Comment 1 by dpa...@chromium.org, Dec 13 2016

Status: Started (was: Untriaged)

Comment 2 by dpa...@chromium.org, Dec 13 2016

Blocking: 597347

Comment 3 by dbeam@chromium.org, Dec 13 2016

Cc: dpranke@chromium.org groby@chromium.org brettw@chromium.org

Comment 4 by dbeam@chromium.org, Dec 13 2016

Labels: -Pri-2 Pri-1

Comment 5 by dpa...@chromium.org, Dec 13 2016 

Listing known blocking issues related to vulcanize tool itself:

1) Make vulcanize return a list of all files that were bundled. PR in progress, https://github.com/Polymer/vulcanize/pull/401.
2) Make vulcanize play nicely with "i18n{}" template string, see diff at https://codereview.chromium.org/2513673005/diff/20001/patch_vulcanize.sh. Need to send a PR for this.

Comment 6 by dpa...@chromium.org, Dec 16 2016 

Status update:
 - Proposal to include NodeJS binaries in Chromium's toolchain has been sent, see [1].
   Will wait a few more days (until Monday?) for feedback, and depending on how that goes
   will continue with the security and open-source review mailing lists.
 - https://codereview.chromium.org/2581383002 shows how to modify the CLs linked in the
   opening comment, to use the third_party/ provided Node and NPM binaries to run our tools,
   instead of relying on whatever is available in the PATH.

Overall path forward looks as follows:
 1) Finish process to make NodeJS binaries available at compile time (address feedback,
    get necessary approvals, land https://codereview.chromium.org/2574033002).
 2) Setup a git repo at https://chromium.googlesource.com to hold all NPM dependencies (and
    update src/DEPS to pull down that repository).
 3) Land all necessary PRs to vulcanize (mentioned in comment#5).
 4) Figure out why GRIT does not handle well inlining within a CSS "background" rule at [2],
    which causes the arrow to be missing from all <select>s in Settings.
 5) Resolve the uglifyjs + for..of operator issue. Either use the newer uglifyjs2 version, or
    remove for..of usage for now.
 6) Start landing the CLs mentioned in the description of this bug.

[1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/H2IqgqwdUqs/4yOxBWIJDQAJ
[2] https://cs.chromium.org/chromium/src/ui/webui/resources/html/md_select_css.html?l=12&dr=C

Comment 7 by aber...@chromium.org, Dec 19 2016

Blocking: 393874
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29c4ba7e0a2d3003db7c7c77c702ed377ab8bceb

commit 29c4ba7e0a2d3003db7c7c77c702ed377ab8bceb
Author: dbeam <dbeam@chromium.org>
Date: Tue Dec 20 19:10:22 2016

MD WebUI: fix vulcanize.py for Windows

R=dpapad@chromium.org
BUG= 673825 
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2594763002
Cr-Commit-Position: refs/heads/master@{#439864}

[modify] https://crrev.com/29c4ba7e0a2d3003db7c7c77c702ed377ab8bceb/chrome/browser/resources/vulcanize.py

Comment 9 by dbeam@chromium.org, Dec 21 2016

Cc: thakis@chromium.org imch...@chromium.org fukino@chromium.org ajo@google.com nduca@chromium.org dfreedm@chromium.org
 Issue 560544  has been merged into this issue.

Comment 10 by tbuck...@chromium.org, Jan 7 2017

Labels: Hotlist-MD-Settings-General
Note that this blocks  Issue 597347 , which is itself a beta-blocker.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbee6ab37edb7df0d8d5354fd2af29e968f33e94

commit cbee6ab37edb7df0d8d5354fd2af29e968f33e94
Author: dpapad <dpapad@chromium.org>
Date: Sat Jan 14 03:05:53 2017

Downloading Node and NPM deps via gclient sync.

This is necessary for WebUI to harness several Node based tools
to speed up performance, as well as remove generated code that is
currently checked in as source code.

Discussion occurred at:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/H2IqgqwdUqs/yn_6_z0cDwAJ

BUG= 673825 

Review-Url: https://codereview.chromium.org/2574033002
Cr-Commit-Position: refs/heads/master@{#443777}

[modify] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/.gitignore
[modify] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/DEPS
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/LICENSE
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/OWNERS
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/README.chromium
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/linux/node-linux-x64.tar.gz.sha1
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/mac/node-darwin-x64.tar.gz.sha1
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/node_modules.tar.gz.sha1
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/npm_exclude.txt
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/package.json
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/update_node_binaries
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/update_npm_deps
[add] https://crrev.com/cbee6ab37edb7df0d8d5354fd2af29e968f33e94/third_party/node/win/node.exe.sha1
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6dfd6a74d424a329c6d46d736fca7552e6fb68b

commit a6dfd6a74d424a329c6d46d736fca7552e6fb68b
Author: dpapad <dpapad@chromium.org>
Date: Mon Jan 23 19:58:15 2017

WebUI: Undo some usages of ES6 features that break uglify.

for..of, let and backticks are currently not supported by uglify. Revert those
usages until uglify is updated to its ES6-aware version.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649663002
Cr-Commit-Position: refs/heads/master@{#445447}

[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/controls/extension_controlled_indicator.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/prefs/prefs.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/site_settings/cookie_info.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/ui/webui/resources/cr_elements/cr_scrollable_behavior.js
[modify] https://crrev.com/a6dfd6a74d424a329c6d46d736fca7552e6fb68b/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f02a25aa9ec8c515ba1a207a4ecf32dc2ab8c57f

commit f02a25aa9ec8c515ba1a207a4ecf32dc2ab8c57f
Author: dbeam <dbeam@chromium.org>
Date: Tue Jan 24 01:58:38 2017

Make vulcanize.md more generic and remove specifics about node modules

Now that node.js is included in Chromium, installing local tools is not
required.

R=dpapad@chromium.org
BUG= 673825 
NOTRY=true

Review-Url: https://codereview.chromium.org/2647203002
Cr-Commit-Position: refs/heads/master@{#445594}

[add] https://crrev.com/f02a25aa9ec8c515ba1a207a4ecf32dc2ab8c57f/docs/optimizing_web_uis.md
[delete] https://crrev.com/6a2436acde75b81198036ed4d27fb1a98d72ddbd/docs/vulcanize.md
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1761cd38fa199b8204a4e17a20599b17bd4b3f0a

commit 1761cd38fa199b8204a4e17a20599b17bd4b3f0a
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Jan 24 17:11:18 2017

MD Settings: Eliminate use of ES6 for Chrome OS

The vulcanization currently fails on ES6 syntax, so remove it for now.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2651483002
Cr-Commit-Position: refs/heads/master@{#445746}

[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/device_page/display_layout.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/device_page/drag_behavior.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/device_page/layout_behavior.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/network_apnlist.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/network_ip_config.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/network_nameservers.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/network_property_list.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/network_proxy.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/chrome/browser/resources/settings/internet_page/network_summary_item.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/ui/webui/resources/cr_elements/network/cr_network_icon.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/ui/webui/resources/cr_elements/network/cr_network_list.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/ui/webui/resources/cr_elements/network/cr_network_list_item.js
[modify] https://crrev.com/1761cd38fa199b8204a4e17a20599b17bd4b3f0a/ui/webui/resources/cr_elements/network/cr_onc_types.js
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07014f0ad6eab4c567845429f84ac6e354c8adba

commit 07014f0ad6eab4c567845429f84ac6e354c8adba
Author: dbeam <dbeam@chromium.org>
Date: Wed Jan 25 03:34:19 2017

MD Downloads: make browser tests work with !use_vulcanize

R=dpapad@chromium.org
BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2651673008
Cr-Commit-Position: refs/heads/master@{#445931}

[modify] https://crrev.com/07014f0ad6eab4c567845429f84ac6e354c8adba/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/07014f0ad6eab4c567845429f84ac6e354c8adba/chrome/test/data/webui/md_downloads/downloads_browsertest.js
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a4bda779e6b2d09a6dac1bdfe86a4732892e8a

commit 18a4bda779e6b2d09a6dac1bdfe86a4732892e8a
Author: dpapad <dpapad@chromium.org>
Date: Wed Jan 25 21:57:05 2017

WebUI: Update vulcanize.py to not process Downloads page anymore.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2654073003
Cr-Commit-Position: refs/heads/master@{#446132}

[modify] https://crrev.com/18a4bda779e6b2d09a6dac1bdfe86a4732892e8a/chrome/browser/resources/vulcanize.py
Project Member

Comment 22 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81fb30fb5ab5c4142b1a3f8fbed7af51ae9b7bef

commit 81fb30fb5ab5c4142b1a3f8fbed7af51ae9b7bef
Author: dbeam <dbeam@chromium.org>
Date: Mon Jan 30 20:16:10 2017

MD Settings: use preprocess=true instead of flattenhtml=true in more places

This reduces the chance of inlinine resources before vulcanize
can have a crack at is.

R=dpapad@chromium.org
BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648323013
Cr-Commit-Position: refs/heads/master@{#447048}

[modify] https://crrev.com/81fb30fb5ab5c4142b1a3f8fbed7af51ae9b7bef/chrome/browser/resources/settings/settings_resources.grd
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b11f78067ea1a8177b014c3afd153f8a155e80a

commit 2b11f78067ea1a8177b014c3afd153f8a155e80a
Author: dpapad <dpapad@chromium.org>
Date: Tue Jan 31 03:54:03 2017

MD Settings: Use relative paths for "src=" where possible.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2658763004
Cr-Commit-Position: refs/heads/master@{#447181}

[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/android_apps_page/android_apps_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/animation/animation.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/animation/animation_group.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_types.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/certificate_manager_page/certificates_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/controls/controlled_radio_button.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/controls/extension_controlled_indicator.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/device_page/device_page_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/device_page/storage.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/direction_delegate.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/extension_control_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/languages_page/languages.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/lifetime_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/on_startup_page/on_startup_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/people_page/change_picture_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/people_page/import_data_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/people_page/lock_screen_constants.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/people_page/profile_info_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/people_page/sync_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/reset_page/reset_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/settings_page/main_page_behavior.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/site_settings/constants.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/site_settings/website_usage_private_api.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/2b11f78067ea1a8177b014c3afd153f8a155e80a/chrome/browser/resources/settings/system_page/system_page_browser_proxy.html
Project Member

Comment 24 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed703ecba76d77c8b8b389382c8d55f876cc772a

commit ed703ecba76d77c8b8b389382c8d55f876cc772a
Author: dpapad <dpapad@chromium.org>
Date: Wed Feb 01 20:33:12 2017

MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing, since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and therefore
a way to reset their value is introduced, by adding PolymerTest.clearBody() and
detached() calls as necessary.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2671493002
Cr-Commit-Position: refs/heads/master@{#447598}

[modify] https://crrev.com/ed703ecba76d77c8b8b389382c8d55f876cc772a/chrome/browser/resources/settings/prefs/prefs.js
[modify] https://crrev.com/ed703ecba76d77c8b8b389382c8d55f876cc772a/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/ed703ecba76d77c8b8b389382c8d55f876cc772a/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/ed703ecba76d77c8b8b389382c8d55f876cc772a/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/ed703ecba76d77c8b8b389382c8d55f876cc772a/chrome/test/data/webui/settings/prefs_tests.js
[modify] https://crrev.com/ed703ecba76d77c8b8b389382c8d55f876cc772a/chrome/test/data/webui/settings/rtl_tests.js
[modify] https://crrev.com/ed703ecba76d77c8b8b389382c8d55f876cc772a/chrome/test/data/webui/settings/system_page_tests.js

Comment 25 by dpa...@chromium.org, Feb 1 2017 

The bot that automatically updates comment seems to have failed the last few hours, so updating manually
https://codereview.chromium.org/2661223003: MD Settings: Add a <base> tag in settings.html.
https://codereview.chromium.org/2664503004: MD Settings: Make all HTML import href's relative.
Project Member

Comment 26 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68c7a441710ebec8b3143eca64f4eb92da482737

commit 68c7a441710ebec8b3143eca64f4eb92da482737
Author: dpapad <dpapad@chromium.org>
Date: Thu Feb 02 19:31:13 2017

MD Settings: Remove unnecessary importHtml() calls in site-settings tests.

Load privacy_page.html as browserPreload in site settings tests to bring in
all necessary dependencies. Previously site settings loaded prefs.html which
does not bring in any of the dependencies needed for the test to run.
Then it programmatically loaded test deps, which is unnecessary.

BUG= 673825 

Review-Url: https://codereview.chromium.org/2673563002
Cr-Commit-Position: refs/heads/master@{#447817}

[modify] https://crrev.com/68c7a441710ebec8b3143eca64f4eb92da482737/chrome/test/data/webui/settings/category_default_setting_tests.js
[modify] https://crrev.com/68c7a441710ebec8b3143eca64f4eb92da482737/chrome/test/data/webui/settings/category_setting_exceptions_tests.js
[modify] https://crrev.com/68c7a441710ebec8b3143eca64f4eb92da482737/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/68c7a441710ebec8b3143eca64f4eb92da482737/chrome/test/data/webui/settings/protocol_handlers_tests.js
[modify] https://crrev.com/68c7a441710ebec8b3143eca64f4eb92da482737/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/68c7a441710ebec8b3143eca64f4eb92da482737/chrome/test/data/webui/settings/usb_devices_tests.js
[modify] https://crrev.com/68c7a441710ebec8b3143eca64f4eb92da482737/chrome/test/data/webui/settings/zoom_levels_tests.js

Comment 27 by dpa...@chromium.org, Feb 2 2017

Blocking: -393874
Project Member

Comment 28 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b69c81cc077bc63f12c61a46528dff5ce22e9985

commit b69c81cc077bc63f12c61a46528dff5ce22e9985
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 03 03:36:24 2017

MD Settings: Remove remaining importHtml() calls from site settings tests.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2669033008
Cr-Commit-Position: refs/heads/master@{#447905}

[modify] https://crrev.com/b69c81cc077bc63f12c61a46528dff5ce22e9985/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/b69c81cc077bc63f12c61a46528dff5ce22e9985/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/b69c81cc077bc63f12c61a46528dff5ce22e9985/chrome/test/data/webui/settings/site_details_tests.js
Project Member

Comment 29 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6ec659f2418eb03341c3f6e37632804d2b7499d

commit a6ec659f2418eb03341c3f6e37632804d2b7499d
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 03 04:22:26 2017

MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Also, using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2670833007
Cr-Commit-Position: refs/heads/master@{#447928}

[modify] https://crrev.com/a6ec659f2418eb03341c3f6e37632804d2b7499d/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/a6ec659f2418eb03341c3f6e37632804d2b7499d/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/a6ec659f2418eb03341c3f6e37632804d2b7499d/chrome/test/data/webui/settings/cr_settings_browsertest.js
Project Member

Comment 30 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505d7a79e8ee2d03d1abcfa14c0bfe64caa6b627

commit 505d7a79e8ee2d03d1abcfa14c0bfe64caa6b627
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 03 19:27:47 2017

MD Settings: Fix quick_unlock_authenticate tests in Vulcanized mode.

The test shouldn't explicitly import load_time_data.js, because in Vulcanized
mode it ends up importing that file twice, whcih throws an error. Instead the
element being tested should depend on i18n_setup.html in the first place.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675863003
Cr-Commit-Position: refs/heads/master@{#448044}

[modify] https://crrev.com/505d7a79e8ee2d03d1abcfa14c0bfe64caa6b627/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/505d7a79e8ee2d03d1abcfa14c0bfe64caa6b627/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
Project Member

Comment 32 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e678fa1a7a3543d5f6f026ea1823af17a54433

commit 56e678fa1a7a3543d5f6f026ea1823af17a54433
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 06 21:08:59 2017

MD WebUI: add node{,_modules}.py as inputs to vulcanize() GN rules

R=dpapad@chromium.org
BUG= 673825 

Review-Url: https://codereview.chromium.org/2674253005
Cr-Commit-Position: refs/heads/master@{#448386}

[modify] https://crrev.com/56e678fa1a7a3543d5f6f026ea1823af17a54433/chrome/browser/resources/vulcanize.gni
Project Member

Comment 33 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/934271eaabb521f8d19d016801459f9ae9eb7ad5

commit 934271eaabb521f8d19d016801459f9ae9eb7ad5
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 07 04:54:48 2017

MD Settings: Fix reset_page_test.js in Vulcanized mode.

ResetProfileBanner was being tested as part of reset_page.html unit
tests, but it is not a dependency of that page, so it was using
importHtml() to load it.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture and remove
   importHtml() call from reset_page_test.js.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676643005
Cr-Commit-Position: refs/heads/master@{#448550}

[modify] https://crrev.com/934271eaabb521f8d19d016801459f9ae9eb7ad5/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/934271eaabb521f8d19d016801459f9ae9eb7ad5/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/934271eaabb521f8d19d016801459f9ae9eb7ad5/chrome/test/data/webui/settings/reset_page_test.js
[add] https://crrev.com/934271eaabb521f8d19d016801459f9ae9eb7ad5/chrome/test/data/webui/settings/reset_profile_banner_test.js
[add] https://crrev.com/934271eaabb521f8d19d016801459f9ae9eb7ad5/chrome/test/data/webui/settings/test_reset_browser_proxy.js
Project Member

Comment 35 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeb737550c55184fea34983f7b7761252944d434

commit aeb737550c55184fea34983f7b7761252944d434
Author: dbeam <dbeam@chromium.org>
Date: Tue Feb 07 19:06:05 2017

MD WebUI: run vulcanize tests on PRESUBMIT

R=dpapad@chromium.org
BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2684673002
Cr-Commit-Position: refs/heads/master@{#448684}

[modify] https://crrev.com/aeb737550c55184fea34983f7b7761252944d434/chrome/browser/resources/PRESUBMIT.py
Project Member

Comment 36 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf54c6ba3a28ace58768bd844cc01f1c6601ee25

commit bf54c6ba3a28ace58768bd844cc01f1c6601ee25
Author: dpapad <dpapad@chromium.org>
Date: Thu Feb 09 08:31:04 2017

WebUI: Fix cr-policy-pref-indicator tooltip to pass accessibilty checks.

Per https://www.w3.org/TR/wai-aria/roles#tooltip the tooltip should be
always referenced by another element via an aria-describedby attribute.
This requires the tooltip itself to have an id.

The bug was uncovered by running MD Settings tests in Vulcanized mode, but was
always there.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2685933004
Cr-Commit-Position: refs/heads/master@{#449233}

[modify] https://crrev.com/bf54c6ba3a28ace58768bd844cc01f1c6601ee25/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
Project Member

Comment 37 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa60e4a929a37c89098b96656ba29e45e8eda0ec

commit fa60e4a929a37c89098b96656ba29e45e8eda0ec
Author: dpapad <dpapad@chromium.org>
Date: Thu Feb 09 22:48:15 2017

MD Settings: Fix CrSettingsPeoplePageSyncPageTest.SyncPage test when Vulcanized.

BUG= 673825 

Review-Url: https://codereview.chromium.org/2688663003
Cr-Commit-Position: refs/heads/master@{#449446}

[modify] https://crrev.com/fa60e4a929a37c89098b96656ba29e45e8eda0ec/chrome/test/data/webui/settings/people_page_sync_page_test.js
Project Member

Comment 38 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0

commit 7bca188f60e1398463fc64d9fdc7eab6bc13d0a0
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 10 01:36:03 2017

MD Settings: Disable MdSettingsUITest.ViewSourceDoesntCrash when Vulcanized.

The test times out on ChromeOS, which indicates that "view source" does not
handle well large files.

BUG= 673825 

Review-Url: https://codereview.chromium.org/2681413002
Cr-Commit-Position: refs/heads/master@{#449509}

[modify] https://crrev.com/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
Project Member

Comment 40 by bugdroid1@chromium.org, Feb 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b40cc378411af0dccf39b5ab74137ae8ac7ea69

commit 9b40cc378411af0dccf39b5ab74137ae8ac7ea69
Author: calamity <calamity@chromium.org>
Date: Sat Feb 11 01:44:57 2017

[MD History] Vulcanize as part of GN build.

This CL removes the need to manually vulcanize MD History by adding the
vulcanization step to the build process.

This CL also:
- changes the request list to be per target-name so that multiple
bundles in the same directory don't overwrite each other's request
lists.
- makes the MD History presubmit check enforce git cl formatting.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2670723002
Cr-Commit-Position: refs/heads/master@{#449824}

[modify] https://crrev.com/9b40cc378411af0dccf39b5ab74137ae8ac7ea69/chrome/browser/BUILD.gn
[modify] https://crrev.com/9b40cc378411af0dccf39b5ab74137ae8ac7ea69/chrome/browser/browser_resources.grd
[add] https://crrev.com/9b40cc378411af0dccf39b5ab74137ae8ac7ea69/chrome/browser/resources/md_history/BUILD.gn
[modify] https://crrev.com/9b40cc378411af0dccf39b5ab74137ae8ac7ea69/chrome/browser/resources/md_history/PRESUBMIT.py
[delete] https://crrev.com/77aa1a3c7c75269bf904d4d447cee5b7052120e2/chrome/browser/resources/md_history/app.crisper.js
[delete] https://crrev.com/77aa1a3c7c75269bf904d4d447cee5b7052120e2/chrome/browser/resources/md_history/app.vulcanized.html
[delete] https://crrev.com/77aa1a3c7c75269bf904d4d447cee5b7052120e2/chrome/browser/resources/md_history/lazy_load.crisper.js
[delete] https://crrev.com/77aa1a3c7c75269bf904d4d447cee5b7052120e2/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/9b40cc378411af0dccf39b5ab74137ae8ac7ea69/chrome/browser/resources/vulcanize.gni
[delete] https://crrev.com/77aa1a3c7c75269bf904d4d447cee5b7052120e2/chrome/browser/resources/vulcanize.py
[modify] https://crrev.com/9b40cc378411af0dccf39b5ab74137ae8ac7ea69/chrome/browser/resources/vulcanize_gn.py
Project Member

Comment 41 by bugdroid1@chromium.org, Feb 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d51c79fa3431c8611fd75fbff0a987831ff0b802

commit d51c79fa3431c8611fd75fbff0a987831ff0b802
Author: dbeam <dbeam@chromium.org>
Date: Sat Feb 11 20:58:07 2017

Remove references to or invocations of vulcanize.py. It's deleted.

Vulcanize now happens dynamically with GN/Ninja. \o/

R=dpapad@chromium.org
BUG= 673825 
NOTRY=true

Review-Url: https://codereview.chromium.org/2690743003
Cr-Commit-Position: refs/heads/master@{#449875}

[modify] https://crrev.com/d51c79fa3431c8611fd75fbff0a987831ff0b802/docs/optimizing_web_uis.md
[modify] https://crrev.com/d51c79fa3431c8611fd75fbff0a987831ff0b802/third_party/polymer/v1_0/reproduce.sh
Project Member

Comment 42 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8375e5cadbe5433e0e9e6e07e8fc6b30d427d3d3

commit 8375e5cadbe5433e0e9e6e07e8fc6b30d427d3d3
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Feb 14 06:13:39 2017

MD Settings: fix vulcanize build ONCE AND FOR ALL

TBR=dpapad@chromium.org
BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2691043006 .
Cr-Commit-Position: refs/heads/master@{#450276}

[modify] https://crrev.com/8375e5cadbe5433e0e9e6e07e8fc6b30d427d3d3/chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.html
[modify] https://crrev.com/8375e5cadbe5433e0e9e6e07e8fc6b30d427d3d3/chrome/browser/resources/settings/people_page/fingerprint_list.html
Project Member

Comment 43 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69

commit e45268fb9d6c1c9c5a57617f6d16e4795c349d69
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 14 07:06:03 2017

WebUI: Vulcanize MD Settings at compile time.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2573943002
Cr-Commit-Position: refs/heads/master@{#450285}

[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/resources/settings/BUILD.gn
[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/resources/settings/settings_resources.grd
[add] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/resources/settings/settings_resources_vulcanized.grd
[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/tools/gritsettings/resource_ids
[modify] https://crrev.com/e45268fb9d6c1c9c5a57617f6d16e4795c349d69/ui/webui/resources/cr_elements/icons.html
Project Member

Comment 44 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a9c3fab1298e8ca3c142be39efffa1b765080f0

commit 6a9c3fab1298e8ca3c142be39efffa1b765080f0
Author: tyoshino <tyoshino@chromium.org>
Date: Tue Feb 14 09:41:08 2017

Revert of WebUI: Vulcanize MD Settings at compile time. (patchset #19 id:420001 of https://codereview.chromium.org/2573943002/ )

Reason for revert:
See http://crbug.com/691965 It looks this caused flakiness.

Original issue's description:
> WebUI: Vulcanize MD Settings at compile time.
>
> BUG= 673825 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2573943002
> Cr-Commit-Position: refs/heads/master@{#450285}
> Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69

TBR=dbeam@chromium.org,thakis@chromium.org,dpapad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 673825 

Review-Url: https://codereview.chromium.org/2693113002
Cr-Commit-Position: refs/heads/master@{#450307}

[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/chrome/browser/resources/BUILD.gn
[delete] https://crrev.com/63636f57f5da37035920e0328c04f0bcd9393d67/chrome/browser/resources/settings/BUILD.gn
[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/chrome/browser/resources/settings/settings_resources.grd
[delete] https://crrev.com/63636f57f5da37035920e0328c04f0bcd9393d67/chrome/browser/resources/settings/settings_resources_vulcanized.grd
[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/tools/gritsettings/resource_ids
[modify] https://crrev.com/6a9c3fab1298e8ca3c142be39efffa1b765080f0/ui/webui/resources/cr_elements/icons.html

Comment 45 by dpa...@chromium.org, Feb 14 2017

Blockedon: 691965
Project Member

Comment 46 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd4c19f45d6e2bba69f9668516a829f39ca9a1f

commit 6bd4c19f45d6e2bba69f9668516a829f39ca9a1f
Author: dbeam <dbeam@chromium.org>
Date: Fri Feb 17 06:15:07 2017

WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=sky@chromium.org
BUG= 673825 ,691965

Review-Url: https://codereview.chromium.org/2654723002
Cr-Commit-Position: refs/heads/master@{#451240}

[modify] https://crrev.com/6bd4c19f45d6e2bba69f9668516a829f39ca9a1f/chrome/common/features.gni
Project Member

Comment 47 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c125f77ab44ad504b5dd8171958aeece8410541e

commit c125f77ab44ad504b5dd8171958aeece8410541e
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Feb 17 09:36:35 2017

MD Settings: fix another vulcanize problem

TBR=sammiequon@chromium.org
BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2696303006 .
Cr-Commit-Position: refs/heads/master@{#451272}

[modify] https://crrev.com/c125f77ab44ad504b5dd8171958aeece8410541e/chrome/browser/resources/settings/people_page/fingerprint_list.html
[modify] https://crrev.com/c125f77ab44ad504b5dd8171958aeece8410541e/chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js
Project Member

Comment 48 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29db19d0c973a8990283ec4b81111db5bdb8d2de

commit 29db19d0c973a8990283ec4b81111db5bdb8d2de
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 17 10:19:34 2017

WebUI: Vulcanize MD Settings at compile time.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2573943002
Cr-Original-Commit-Position: refs/heads/master@{#450285}
Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69
Review-Url: https://codereview.chromium.org/2573943002
Cr-Commit-Position: refs/heads/master@{#451275}

[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/resources/settings/BUILD.gn
[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/resources/settings/settings_resources.grd
[add] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/resources/settings/settings_resources_vulcanized.grd
[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/tools/gritsettings/resource_ids
[modify] https://crrev.com/29db19d0c973a8990283ec4b81111db5bdb8d2de/ui/webui/resources/cr_elements/icons.html
Project Member

Comment 49 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14f051ba2a0c49946e279d0beaaef33f6287a7ed

commit 14f051ba2a0c49946e279d0beaaef33f6287a7ed
Author: mikecase <mikecase@chromium.org>
Date: Fri Feb 17 17:43:08 2017

Revert of WebUI: Vulcanize MD Settings at compile time. (patchset #20 id:440001 of https://codereview.chromium.org/2573943002/ )

Reason for revert:
Causing compilation failures on Android Perf bots.

See crbug/693619

Original issue's description:
> WebUI: Vulcanize MD Settings at compile time.
>
> BUG= 673825 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2573943002
> Cr-Original-Commit-Position: refs/heads/master@{#450285}
> Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69
> Review-Url: https://codereview.chromium.org/2573943002
> Cr-Commit-Position: refs/heads/master@{#451275}
> Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de

TBR=dbeam@chromium.org,thakis@chromium.org,dpapad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 673825 

Review-Url: https://codereview.chromium.org/2700983003
Cr-Commit-Position: refs/heads/master@{#451333}

[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/chrome/browser/resources/BUILD.gn
[delete] https://crrev.com/9622db880c5abd5dabad67c152f5146044bf4ede/chrome/browser/resources/settings/BUILD.gn
[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/chrome/browser/resources/settings/settings_resources.grd
[delete] https://crrev.com/9622db880c5abd5dabad67c152f5146044bf4ede/chrome/browser/resources/settings/settings_resources_vulcanized.grd
[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/tools/gritsettings/resource_ids
[modify] https://crrev.com/14f051ba2a0c49946e279d0beaaef33f6287a7ed/ui/webui/resources/cr_elements/icons.html

Comment 50 by dpa...@chromium.org, Feb 17 2017

Blockedon: 693619
Project Member

Comment 51 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da

commit fb1a92c477c4dc2f72fdbeaa28b09b632cd928da
Author: agrieve <agrieve@chromium.org>
Date: Fri Feb 17 23:38:12 2017

Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place

BUG= 673825 , 693619 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2696763003
Cr-Commit-Position: refs/heads/master@{#451398}

[modify] https://crrev.com/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da/chrome/BUILD.gn
[modify] https://crrev.com/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da/chrome/browser/BUILD.gn
[modify] https://crrev.com/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da/chrome/browser/resources/BUILD.gn
Project Member

Comment 52 by bugdroid1@chromium.org, Feb 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e

commit 2d84fd7e2cdb13ae3fbe894319ef828febd14f0e
Author: dpapad <dpapad@chromium.org>
Date: Sat Feb 18 04:12:57 2017

WebUI: Vulcanize MD Settings at compile time.

BUG= 673825 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2573943002
Cr-Original-Original-Commit-Position: refs/heads/master@{#450285}
Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69
Review-Url: https://codereview.chromium.org/2573943002
Cr-Original-Commit-Position: refs/heads/master@{#451275}
Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de
Review-Url: https://codereview.chromium.org/2573943002
Cr-Commit-Position: refs/heads/master@{#451417}

[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/resources/settings/BUILD.gn
[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/resources/settings/settings_resources.grd
[add] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/resources/settings/settings_resources_vulcanized.grd
[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/tools/gritsettings/resource_ids
[modify] https://crrev.com/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e/ui/webui/resources/cr_elements/icons.html

Comment 53 by dbeam@chromium.org, Feb 21 2017 

shall we mark this fixed?

Comment 54 by dpa...@chromium.org, Feb 21 2017

Status: Fixed (was: Started)
Yes. All of History, Settings, Downloads WebUIs are now vulcanized during compile time. We can file separate bugs for any new issues regarding vulcanize.
Project Member

Comment 55 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/133b4458dc3c57dd9d1212f5a35abc48e352b550

commit 133b4458dc3c57dd9d1212f5a35abc48e352b550
Author: calamity <calamity@chromium.org>
Date: Tue Feb 28 05:57:24 2017

[MD WebUI] Use html_out_file as prefix for depfile.

This CL fixes an issue where changing the out file of a vulcanize build
would not cause the depfile to be retargeted, leading to a stale depfile
and breaking builds.

BUG= 673825 

Review-Url: https://codereview.chromium.org/2720223002
Cr-Commit-Position: refs/heads/master@{#453515}

[modify] https://crrev.com/133b4458dc3c57dd9d1212f5a35abc48e352b550/chrome/browser/resources/vulcanize.gni
►

Sign in to add a comment