New issue
Advanced search Search tips

Issue 673820 link

Starred by 1 user
Status: Fixed
Owner:
rajendrant@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Record histograms to record tab state during data use

Project Member Reported by rajendrant@chromium.org, Dec 13 2016 
Following histograms should be recorded that indicate the data use of tabs in background vs. foreground.

DataUse.AppBackground
DataUse.AppForeground.TabBackground
DataUse.AppForeground.TabForeground

Following histograms should be recorded that indicate the content type of the data use.

DataUse.ContentType.[User|System].[Background|Foreground]
  MainFrameHTML
  NonMainFrameHTML
  CSS
  Image
  Javascript
  Font
  AudioForegroundTab
  AudioBackgroundTab
  AudioBackgroundApp
  VideoForegroundTab
  VideoBackgroundTab
  VideoBackgroundApp
  Other
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc0257d91a4a619fce84d274681f2bbc7f1c92b7

commit fc0257d91a4a619fce84d274681f2bbc7f1c92b7
Author: rajendrant <rajendrant@chromium.org>
Date: Thu Dec 15 21:04:23 2016

Propogate the tab foreground, background change events to data use

This CL observes WebContents visibility changes to record if a data use
entity (Chromium tab) is in foreground vs background. Further CLs will
record the histograms.

BUG= 673820 

Review-Url: https://codereview.chromium.org/2572823002
Cr-Commit-Position: refs/heads/master@{#438922}

[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/chrome/browser/data_use_measurement/data_use_web_contents_observer.h
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/components/data_use_measurement/core/data_use_recorder.cc
[modify] https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7/components/data_use_measurement/core/data_use_recorder.h
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a

commit f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a
Author: rajendrant <rajendrant@chromium.org>
Date: Tue Dec 20 07:54:37 2016

Record the tab state during data use

DataUse.AppTabState UMA is recorded with the following dimensions.
  Upstream.AppBackground
  Upstream.AppForeground.TabBackground
  Upstream.AppForeground.TabForeground
  Downstream.AppBackground
  Downstream.AppForeground.TabBackground
  Downstream.AppForeground.TabForeground

BUG= 673820 

Review-Url: https://codereview.chromium.org/2583703002
Cr-Commit-Position: refs/heads/master@{#439742}

[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/components/data_use_measurement/core/data_use_ascriber.cc
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/components/data_use_measurement/core/data_use_ascriber.h
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/components/data_use_measurement/core/data_use_measurement.h
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/components/data_use_measurement/core/data_use_measurement_unittest.cc
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/components/data_use_measurement/core/data_use_network_delegate.cc
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/components/data_use_measurement/core/data_use_network_delegate_unittest.cc
[modify] https://crrev.com/f3ccb26f8d14aa3aff875d0b4e097568b2ec9b8a/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a98850d939429e57c8a827adcb1e9f4760cb2db2

commit a98850d939429e57c8a827adcb1e9f4760cb2db2
Author: rajendrant <rajendrant@chromium.org>
Date: Wed Jan 04 02:34:00 2017

Record the data use by content type

BUG= 673820 

Review-Url: https://codereview.chromium.org/2595503002
Cr-Commit-Position: refs/heads/master@{#441298}

[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/content/BUILD.gn
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/content/DEPS
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/content/content_url_request_classifier.cc
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/content/content_url_request_classifier.h
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_ascriber.cc
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_measurement.h
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_measurement_unittest.cc
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_network_delegate.cc
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_network_delegate.h
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_network_delegate_unittest.cc
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/components/data_use_measurement/core/url_request_classifier.h
[modify] https://crrev.com/a98850d939429e57c8a827adcb1e9f4760cb2db2/tools/metrics/histograms/histograms.xml

Comment 4 by rajendrant@chromium.org, Jan 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment