New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673803 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Docked window resizes after switching user

Project Member Reported by abodenha@chromium.org, Dec 13 2016

Issue description

See attached images. When using fast switch between users, the bottom of a docked window will go from touching top of the shelf to touching bottom of the shelf (and overlapping with shelf).

Steps to reproduce:
1) Log into 2 users at the same time, and can fast-switch using Ctrl+Alt+Period.
2) Dock a window to either side of the screen. Bottom of the window is now touching top of the shelf.
3) Fast-switch to a different user, then switch back.
3) Now bottom of the window is touching bottom of the shelf, with the lower part of the window behind the shelf.

The bug causes problem to editing code within Critique, where the Save button is covered by the shelf. It also causes problem to SshInATable, etc.
 
Attached images :D
before.png
2.7 MB View Download
after.png
2.6 MB View Download
Ooops. Thanks for catching that.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/962f4ece9b5b3efa7e2cc3f0dde56cd08d9ad176

commit 962f4ece9b5b3efa7e2cc3f0dde56cd08d9ad176
Author: warx <warx@chromium.org>
Date: Wed Dec 21 03:08:38 2016

ash: Should use GetTargetBounds to check call of SetBoundsDirectAnimated

Changes:
Because window's layer might be doing animation, in default_state.cc we should use GetTargetBounds to check call of SetBoundsDirectAnimated, otherwise it might miss the required bounds update in the case of 673803.

BUG= 673803 
TEST=emulator test; also add test coverage.

Review-Url: https://codereview.chromium.org/2589793002
Cr-Commit-Position: refs/heads/master@{#439992}

[modify] https://crrev.com/962f4ece9b5b3efa7e2cc3f0dde56cd08d9ad176/ash/common/wm/default_state.cc
[modify] https://crrev.com/962f4ece9b5b3efa7e2cc3f0dde56cd08d9ad176/ash/common/wm/workspace/workspace_layout_manager_unittest.cc

Comment 4 by warx@chromium.org, Dec 21 2016

Status: Fixed (was: Assigned)

Comment 5 by warx@chromium.org, Dec 23 2016

Cc: x...@chromium.org
 Issue 520925  has been merged into this issue.

Comment 6 by warx@chromium.org, Dec 23 2016

Cc: skuhne@chromium.org varkha@chromium.org osh...@chromium.org
 Issue 529314  has been merged into this issue.

Comment 7 by warx@chromium.org, Feb 21 2017

Cc: warx@chromium.org
 Issue 693171  has been merged into this issue.

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Status: Verified (was: Fixed)
Chrome OS 9460.5.0/59.0.3071.15

Sign in to add a comment