New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673775 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 664505



Sign in to add a comment

Fix and re-enable browse:search:google on windows

Project Member Reported by perezju@chromium.org, Dec 13 2016

Issue description

The browser is crashing on Win 7 and Win 7 x64 bots while running this story with:

	Last event: c74.2f8: Access violation - code c0000005 (first/second chance not available)
	  debugger time: Tue Dec 13 02:03:56.930 2016 (UTC - 8:00)
	ChildEBP RetAddr  Args to Child
	002be7e0 6d8ba51a 0e076f88 00000000 6d8ba51a chrome_6cae0000!content::SyntheticGestureTargetBase::DispatchInputEventToPlatform+0x130
	002be7fc 6d8b9fbe 0e076f88 002be828 002be884 chrome_6cae0000!content::SyntheticMouseDriver::DispatchEvent+0x1b
	002be830 6d8b9b45 002be884 0e076f88 6f0fd86c chrome_6cae0000!content::SyntheticSmoothMoveGesture::ForwardTouchInputEvents+0x17b
	002be84c 6d8b8808 00000000 0e076f88 0e076868 chrome_6cae0000!content::SyntheticSmoothMoveGesture::ForwardInputEvents+0x6f
	002be87c 6d8ec057 fc6b5193 00000001 0952a2d0 chrome_6cae0000!content::SyntheticGestureController::Flush+0x7f
	002be898 6d8f3ea9 0e076868 0e077120 00000000 chrome_6cae0000!content::RenderWidgetHostImpl::FlushInput+0x33
	002be8ac 6d44cab0 002be908 002bf368 08fd00f8 chrome_6cae0000!content::RenderWidgetHostViewAura::OnBeginFrame+0x1b
	002be928 6d44f313 08fd00f8 00000000 fc6b5190 chrome_6cae0000!cc::DelayBasedBeginFrameSource::OnTimerTick+0x1a0
	002be940 6cbdeb54 08fd0128 00000000 002be96c chrome_6cae0000!cc::DelayBasedTimeSource::OnTimerTick+0x43
	002be950 6d44fa53 0dfb3628 6cbdeb54 0dfb2e80 chrome_6cae0000!base::internal::Invoker<base::internal::BindState<void (__thiscall base::CancelableCallback<void __cdecl(void)>::*)(void)const ,base::WeakPtr<base::CancelableCallback<void __cdecl(void)> > >,void __cdecl(void)>::Run+0x34
	002be958 6cbdeb54 0dfb2e80 00000000 fc6b50e9 chrome_6cae0000!base::CancelableCallback<void __cdecl(void)>::Forward+0x13
	002be96c 6d1e9d89 0dfb2e80 002bf368 00c594c0 chrome_6cae0000!base::internal::Invoker<base::internal::BindState<void (__thiscall base::CancelableCallback<void __cdecl(void)>::*)(void)const ,base::WeakPtr<base::CancelableCallback<void __cdecl(void)> > >,void __cdecl(void)>::Run+0x34
	002be9d8 6d1a793e 6f04f30c 002bf368 00c54588 chrome_6cae0000!base::debug::TaskAnnotator::RunTask+0x179
	002bf34c 6d1a7ae0 002bf368 00c594c0 fc6b50e9 chrome_6cae0000!base::MessageLoop::RunTask+0x30e
	002bf360 6d1a8429 09119188 008227c2 fc6b50e9 chrome_6cae0000!base::MessageLoop::DeferOrRunPendingTask+0x30
	002bf3e4 6d1ea3b7 00c54588 00000000 00c54580 chrome_6cae0000!base::MessageLoop::DoDelayedWork+0xb9
	002bf418 6d1e9f35 00000000 002bf484 00c594c0 chrome_6cae0000!base::MessagePumpForUI::DoRunLoop+0x77
	002bf444 6d1bfd9d 00c594c0 00c59360 6e48c217 chrome_6cae0000!base::MessagePumpWin::Run+0x55
	002bf470 6db1749e 00000000 024d20b0 6f04f300 chrome_6cae0000!base::RunLoop::Run+0x5d
	002bf4a8 6d78ca5b 024d20c0 ffffffff 00c5e4a8 chrome_6cae0000!ChromeBrowserMainParts::MainMessageLoopRun+0x95
	002bf4bc 6d78da83 00c5e4a8 00000000 002bf4e4 chrome_6cae0000!content::BrowserMainLoop::RunMainMessageLoopParts+0x50
	002bf4cc 6d7898c0 00000000 00c24050 00c24100 chrome_6cae0000!content::BrowserMainRunnerImpl::Run+0x13
	002bf4e4 6dad94c8 002bf51c 00000000 00000000 chrome_6cae0000!content::BrowserMain+0x82
	002bf4f8 6dad9436 002bf534 002bf51c 002bf570 chrome_6cae0000!content::RunNamedProcessTypeMain+0x61
	002bf550 6dad8c13 004deeb8 6ec24814 002bf5a0 chrome_6cae0000!content::ContentMainRunnerImpl::Run+0x97
	002bf560 6d55f4fc 002bf58c 6d55f473 6eafb148 chrome_6cae0000!content::ContentMain+0x23
	*** WARNING: Unable to verify checksum for chrome.exe
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_Perf%2F72%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.memory_desktop_on__102b__GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Fstdout

Full crash log attached.

Interestingly, the story seems to run fine on other Win bots (ATI GPU, Intel GPU, WIN 8, etc.). For example:

[ RUN      ] c:\b\s\w\itxh2v2j\tmpvlnkfq.html
[       OK ] c:\b\s\w\itxh2v2j\tmpvlnkfq.html (1088 ms)
[       OK ] browse:search:google (42950 ms)
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_ATI_GPU_Perf%2F74%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.memory_desktop_on_ATI_GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Fstdout

I'm proceeding to disable the story on windows.
 
Actually attaching the full crash log.
crash.txt
40.8 KB View Download
Any idea why the CQ is not blocked by this? :-(
Owner: tdres...@chromium.org
Status: Untriaged (was: Available)
Tim: since this is an input related stack, can you help triage this?
Owner: lanwei@chromium.org
Status: Assigned (was: Untriaged)
This is related to Lan's recent work.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a40ee20de10c52fbfa6609a2266e1bbc45516408

commit a40ee20de10c52fbfa6609a2266e1bbc45516408
Author: perezju <perezju@chromium.org>
Date: Tue Dec 13 17:44:45 2016

Disable browse:search:google on windows

The browser crashes when trying to run this story.

BUG=673775

Review-Url: https://codereview.chromium.org/2570883002
Cr-Commit-Position: refs/heads/master@{#438214}

[modify] https://crrev.com/a40ee20de10c52fbfa6609a2266e1bbc45516408/tools/perf/page_sets/system_health/browsing_stories.py

This recently started failing on mac:

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests

Potential regression range:
https://test-results.appspot.com/revision_range?start=478387&end=478412

Can someone on this bug look into this, and/or do any of those commits look particularly suspicious?  I'm hesitant to disable the tests on mac as well, but nothing in the revision log jumps out at me as being a likely culprit.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d465b020edee0d078775f731d87140901ec2b779

commit d465b020edee0d078775f731d87140901ec2b779
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Wed Aug 09 18:55:26 2017

Re-enable v8.browsing_desktiop/browse:search:google on win.

Bug: chromium:673775
Change-Id: Ie7314ca87cebf2037c45131dceab37ab9cac96ef
Reviewed-on: https://chromium-review.googlesource.com/605892
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493081}
[modify] https://crrev.com/d465b020edee0d078775f731d87140901ec2b779/tools/perf/page_sets/system_health/expectations.py

Status: Fixed (was: Assigned)
Owner: ----
Status: Available (was: Fixed)
This story is still disabled on some platforms and benchmarks.
Owner: tdres...@chromium.org
Status: Assigned (was: Available)
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/16e3abd5a40000
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50bc725931feb3e09cdd424ef8369fd6cc17cb01

commit 50bc725931feb3e09cdd424ef8369fd6cc17cb01
Author: Tim Dresser <tdresser@chromium.org>
Date: Mon Jul 30 18:00:27 2018

Enable browse:search:google

Passing pinpoint job here:
https://pinpoint-dot-chromeperf.appspot.com/job/16e3abd5a40000

Bug: 673775
Change-Id: I98cb4f3099b25512e0dc36c3adbc6f8b890fe46d
Reviewed-on: https://chromium-review.googlesource.com/1143596
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579086}
[modify] https://crrev.com/50bc725931feb3e09cdd424ef8369fd6cc17cb01/tools/perf/expectations.config

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12bc86eba40000
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba9f84b01d023e8487dcf11180ef8c44765e6812

commit ba9f84b01d023e8487dcf11180ef8c44765e6812
Author: Nicolas Pena <npm@chromium.org>
Date: Thu Aug 02 20:01:28 2018

Reenable system_health.common_desktop/browse:search:google

Bug: 673775
Change-Id: Id385dfce82e2a31da523a0dd41c656ce0c648c6f
Reviewed-on: https://chromium-review.googlesource.com/1157262
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580291}
[modify] https://crrev.com/ba9f84b01d023e8487dcf11180ef8c44765e6812/tools/perf/expectations.config

Sign in to add a comment