[PlzNavigate] "RendererCrash" tests pass for the wrong reasons |
|||
Issue descriptionThe browser_tests: PrerenderBrowserTest.PrerenderRendererCrash NoStatePrefetchBrowserTest.RendererCrash are supposed to check that crashing the prerender is recorded as FINAL_STATUS_RENDERER_CRASHED. They do this by launching a prerender of chrome://crash. With PlzNavigate though, no renderer is created for the main navigation, and nothing crashes. It returns a FINAL_STATUS_UNSUPPORTED_SCHEME status (which is expected because we don't support prerendering chrome:// urls). The tests pass currently though, because of other bugs and incomplete support of PlzNavigate in prerendering code. Adding correct support for PlzNavigate is surfacing this.
,
Dec 14 2016
,
Dec 14 2016
Normally we special case the debug urls like chrome://crash and have them commit immediately, without being sent to the network stack.
,
Dec 15 2016
For future reference, in the fix [1] droger@ says: > The reason why it was failing the test is a bit complex. Here are some > explanations for posterity: > > This was making the test fail because it would cause > FINAL_STATUS_UNSUPPORTED_SCHEME when requesting chrome://crash instead of > letting it go through and crashing the rendrerer. > > This was only happening with plz navigate because of an ordering issue: with plz > navigate this code is called before the renderer is invoked, whereas with the > old flow the renderer is invoked first (and crashes before running this code). > > Note that chrome://crash is able to go through in the test, because the check > for unsupported URLs in PrerenderContents is specifically disabled by > TestPrerenderContents. > So in real life, prerendering chrome://crash would not crash the prerenderer, it > only can do so in the test. [1] https://codereview.chromium.org/2576443002/
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78a01d19d3321e75787d5d77a0e4e7006d1269c9 commit 78a01d19d3321e75787d5d77a0e4e7006d1269c9 Author: droger <droger@chromium.org> Date: Thu Dec 15 17:12:32 2016 [PlzNavigate] Use WebContentsGetter in PrerenderResourceThrottle BUG= 668714 , 673771 Review-Url: https://codereview.chromium.org/2576443002 Cr-Commit-Position: refs/heads/master@{#438854} [modify] https://crrev.com/78a01d19d3321e75787d5d77a0e4e7006d1269c9/chrome/browser/prerender/prerender_resource_throttle.cc [modify] https://crrev.com/78a01d19d3321e75787d5d77a0e4e7006d1269c9/chrome/browser/prerender/prerender_resource_throttle.h
,
Jan 2 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pasko@chromium.org
, Dec 14 2016Labels: -Pri-3 OS-All Pri-2
Status: Assigned (was: Untriaged)