telemetry.core.tracing_controller_unittest.TracingControllerTest.testBattOrTracing is failing on chromium.linux/Linux Tests |
||||||
Issue description
,
Dec 13 2016
Test disabling: https://codereview.chromium.org/2570463007
,
Dec 13 2016
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d33c5b94f5a023fb083d4757fe936263c1f75e6 commit 1d33c5b94f5a023fb083d4757fe936263c1f75e6 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Tue Dec 13 17:53:20 2016 Roll src/third_party/catapult/ e6e0862c8..bf0f62a28 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e6e0862c8165..bf0f62a28351 $ git log e6e0862c8..bf0f62a28 --date=short --no-merges --format='%ad %ae %s' 2016-12-13 nednguyen [Telemetry] Disable testBattOrTracing on linux BUG= 673761 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2577433002 Cr-Commit-Position: refs/heads/master@{#438219} [modify] https://crrev.com/1d33c5b94f5a023fb083d4757fe936263c1f75e6/DEPS
,
Dec 14 2016
Removing sheriff label - disabled and assigned.
,
Dec 29 2016
Ned, it looks like the remaining problem here is that this test requires a binary download from cloud storage in order to run (the BattOr agent). However, telemetry/bin/run_tests specifically prohibits any interaction with cloud storage (https://github.com/catapult-project/catapult/blob/1e8a2ca77b59f3df03c22afe334d92b725df020c/telemetry/bin/run_tests#L21), so when we go to download the agent, things blow up. Any suggestions on what the right thing to do here is?
,
Dec 29 2016
Telemetry should have downloaded all the required binaries before running any tests in https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/testing/run_tests.py#L144
,
Dec 29 2016
Ned and I troubleshooted this some offline. It looks like the problem was that battor_wrapper.py was trying to access the battor_agent for the platform "linux2_x86_64", whereas the battor_agent was attemping to prefetch for platform "linux_x86_64". The reason for the discrepancy is that Telemetry does some massaging of sys.platform in order to get the Telemetry target_platform, and part of this massaging is stripping any trailing numbers from "linux" in order to work around http://stackoverflow.com/questions/10415942/python-sys-platform-linux2-but-not-linux3. The prefetch was working based off of the target_platform, but the runtime fetch attempt, which should have resulted in a hit of the prefetch cache, was working based off of sys.platform. I've verified locally that changing battor_wrapper and the battor_binary_dependencies.json to use target_platform and "linux" over "linux2", respectively, solves the problem.
,
Jan 22 2018
Adding Test-Disabled label, the Tests>Disabled component is going away.
,
Jan 23 2018
This was fixed a loooong time ago. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nedngu...@google.com
, Dec 13 2016Status: Assigned (was: Available)