New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673752 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Upcoming Skia path rendering change will require pixel test suppression

Project Member Reported by jvanverth@chromium.org, Dec 13 2016

Issue description

https://skia-review.googlesource.com/c/5697/ (Fix SDF generation for pixel-aligned paths (take two)) has and will once more alter the following GPU pixel test:

Pixel_CSS3DBlueBox


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/103f8935e4b9006fa01f69411cd8f839e53577d6

commit 103f8935e4b9006fa01f69411cd8f839e53577d6
Author: jvanverth <jvanverth@chromium.org>
Date: Tue Dec 13 21:36:25 2016

Disable CSS3DBlueBox pixel test.

A change in Skia has affected the antialiasing for certain paths, so
this test needs to be rebaselined.

BUG= 673752 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2570863002
Cr-Commit-Position: refs/heads/master@{#438283}

[modify] https://crrev.com/103f8935e4b9006fa01f69411cd8f839e53577d6/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2368e09cd19ffafc612f28f9249ec74bacd35c17

commit 2368e09cd19ffafc612f28f9249ec74bacd35c17
Author: jvanverth <jvanverth@chromium.org>
Date: Fri Dec 16 15:20:39 2016

Bump CSS3DBlueBox pixel test revision number to force rebaseline.

BUG= 673752 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2579053002
Cr-Commit-Position: refs/heads/master@{#439107}

[modify] https://crrev.com/2368e09cd19ffafc612f28f9249ec74bacd35c17/content/test/gpu/gpu_tests/pixel_test_pages.py

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0b9e6b14c142dd335805f8713f4b759775d8529

commit c0b9e6b14c142dd335805f8713f4b759775d8529
Author: jvanverth <jvanverth@chromium.org>
Date: Tue Dec 20 16:33:01 2016

Re-enable CSS3DBlueBox pixel test.

Rebaselines for this test should be complete.

BUG= 673752 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2588033003
Cr-Commit-Position: refs/heads/master@{#439820}

[modify] https://crrev.com/c0b9e6b14c142dd335805f8713f4b759775d8529/content/test/gpu/gpu_tests/pixel_expectations.py

Sign in to add a comment