PlzNavigate: cross frame access should work |
||
Issue descriptionhttp/tests/security/cross-frame-access-parent-isolated-world.html and http/tests/security/cross-frame-access-parent-explicit-domain-isolated-world.html are currently timeouting when PlzNavigate is enabled. This should be fixed.
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f59dc823911d1e7fca195b638638e8458c631491 commit f59dc823911d1e7fca195b638638e8458c631491 Author: ananta <ananta@chromium.org> Date: Fri Jan 20 21:35:46 2017 PlzNavigate: Fix the http/tests/security/cross-frame-access-parent-isolated-world.html and http/tests/security/cross-frame-access-parent-explicit-domain-isolated-world.html layout tests. These tests instantiate an iframe with the following src "data:text/html," and then later on switch the iframe src to a different URL to run the security tests. With PlzNavigate when the iframe is instantiated, we send the navigation off to the browser via RenderFrameImpl::BeginNavigation. This function gets called in the decidePolicyForNavigation code path. When this returns blink eventually schedules a task for switching the navigation src url for the iframe via a call to the NavigationScheduler::scheduleLocationChange which is called in the LocalFrame::navigate function. Before this scheduled task runs, the CommitNavigation IPC comes back from the browser and the original load completes for the iframe which cancels pending navigations on the iframe. As a result the task never runs and the test times out. Without PlzNavigate this does not happen as the original load on the iframe is completed by the time the task runs. It looks like fixing the layout test itself to switch the src on the iframe after it finishes loading is one approach. Alternatively we could avoid cancelling pending navigations for plznavigate. Exceptions being user initiated navigations. BUG= 673748 Review-Url: https://codereview.chromium.org/2630783003 Cr-Commit-Position: refs/heads/master@{#445174} [modify] https://crrev.com/f59dc823911d1e7fca195b638638e8458c631491/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation [modify] https://crrev.com/f59dc823911d1e7fca195b638638e8458c631491/third_party/WebKit/Source/core/loader/FrameLoader.cpp
,
Feb 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ananta@chromium.org
, Jan 12 2017Status: Assigned (was: Untriaged)