New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673745 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 576261



Sign in to add a comment

PlzNavigate: Resource transfer size should be forwarded to blink

Project Member Reported by clamy@chromium.org, Dec 13 2016

Issue description

http/tests/misc/resource-timing-sizes-tags.html is failing because we do not forward the right size. This may also be causing http/tests/inspector/resource-har-conversion.html to fail. The latter expects to get an encoded transfer size, which is normally passed by the AsyncResourceHandler, which may get the size wrong when PlzNavigate is enabled.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a9167f903f8aae02ca586fb920348a71d573544

commit 0a9167f903f8aae02ca586fb920348a71d573544
Author: ananta <ananta@chromium.org>
Date: Wed Jan 04 18:11:16 2017

PlzNavigate: Pass the encoded resource transfer size to the renderer.

This should fix the http/tests/misc/resource-timing-sizes-tags.html layout test.
The other test http/tests/inspector/resource-har-conversion.html needs an expectation
change to allow the custom header which is passed for PlzNavigate. Will do that in a later
patchset.

Changes on this patch are to implement the GetTotalReceivedBytes() override for the StreamURLRequestJob class

BUG= 673745 

Review-Url: https://codereview.chromium.org/2612683002
Cr-Commit-Position: refs/heads/master@{#441409}

[modify] https://crrev.com/0a9167f903f8aae02ca586fb920348a71d573544/content/browser/streams/stream_url_request_job.cc
[modify] https://crrev.com/0a9167f903f8aae02ca586fb920348a71d573544/content/browser/streams/stream_url_request_job.h
[modify] https://crrev.com/0a9167f903f8aae02ca586fb920348a71d573544/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c22f660541434f9666391a38895d4d20d487d03

commit 9c22f660541434f9666391a38895d4d20d487d03
Author: ananta <ananta@chromium.org>
Date: Wed Jan 11 02:28:29 2017

PlzNavigate: Fix for the http/tests/inspector/resource-har-conversion.html layout test failure.

This test turns off caching for the reload request initiated via the DevTools network agent.
Without PlzNavigate, this goes through the normal resource load path, where in
RenderFrameImpl::decidePolicyForNavigation is invoked after which the cache policy is set in
the WebURLRequest to disabled correctly.

With PlzNavigate, the reload request is sent out to the browser via the BeginNavigate IPC
in RenderFrameImpl::decidePolicyForNavigation() and we indicate  to blink that the client
handled the request.

As a result the cache policy does not get set to disabled.

Fix is to add query the dev tools agent if caching is disabled. To achieve this following changes
were needed.
1. Add a virtual function cacheDisabled() to the WebDevToolsAgent class.
2. This function calls to the newly added cacheDisabled() function in the InspectorNetworkAgent class.
   which checks the state variable for the same.

BUG= 673745 

Review-Url: https://codereview.chromium.org/2611183007
Cr-Commit-Position: refs/heads/master@{#442773}

[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/public/web/WebDevToolsAgent.h
[modify] https://crrev.com/9c22f660541434f9666391a38895d4d20d487d03/third_party/WebKit/public/web/WebFrameClient.h

Comment 3 by ananta@chromium.org, Jan 11 2017

Status: Fixed (was: Untriaged)

Comment 4 by ananta@chromium.org, Jan 13 2017

Owner: ananta@chromium.org

Sign in to add a comment