Ensure that changes in the section order are always propagated to the UI |
|||
Issue descriptionWe are going to have dynamic rankers and it is not clear whether (or when) the changes in the order will be propagated to the UI.
,
Dec 14 2016
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b5ab2844d4cb92e7abfefceea86e83e18f7da28 commit 8b5ab2844d4cb92e7abfefceea86e83e18f7da28 Author: vitaliii <vitaliii@chromium.org> Date: Tue Dec 20 11:06:22 2016 [NTP::SectionOrder] Propagate new order through ContentSuggestionsService. Previously, |GetCategories()| did not update the order and, therefore, order changes could not be propagated to UI. After this CL, |GetCategories()| refreshes the order before returning +1 test. BUG= 673743 Review-Url: https://codereview.chromium.org/2581163004 Cr-Commit-Position: refs/heads/master@{#439766} [modify] https://crrev.com/8b5ab2844d4cb92e7abfefceea86e83e18f7da28/components/ntp_snippets/BUILD.gn [add] https://crrev.com/8b5ab2844d4cb92e7abfefceea86e83e18f7da28/components/ntp_snippets/category_rankers/fake_category_ranker.cc [add] https://crrev.com/8b5ab2844d4cb92e7abfefceea86e83e18f7da28/components/ntp_snippets/category_rankers/fake_category_ranker.h [modify] https://crrev.com/8b5ab2844d4cb92e7abfefceea86e83e18f7da28/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/8b5ab2844d4cb92e7abfefceea86e83e18f7da28/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/8b5ab2844d4cb92e7abfefceea86e83e18f7da28/components/ntp_snippets/content_suggestions_service_unittest.cc
,
Dec 20 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted