New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673729 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 673433



Sign in to add a comment

"org.chromium.chrome.browser.tabmodel.UndoTabModelTest#testReverseOrderRestore" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 13 2016

Issue description

"org.chromium.chrome.browser.tabmodel.UndoTabModelTest#testReverseOrderRestore" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWAsSBUZsYWtlIk1vcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIudGFibW9kZWwuVW5kb1RhYk1vZGVsVGVzdCN0ZXN0UmV2ZXJzZU9yZGVyUmVzdG9yZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: dfalcant...@chromium.org
Disabling in https://codereview.chromium.org/2572753002/
This may have been related to issue 673433. Will look later today.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eae967f8220868aa2ac64f04a1fb636f97c5aa2

commit 7eae967f8220868aa2ac64f04a1fb636f97c5aa2
Author: nednguyen <nednguyen@google.com>
Date: Tue Dec 13 14:02:54 2016

Disable tabmodel.UndoTabModelTest#testReverseOrderRestore

BUG= 673729 
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2572753002
Cr-Commit-Position: refs/heads/master@{#438158}

[modify] https://crrev.com/7eae967f8220868aa2ac64f04a1fb636f97c5aa2/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

Labels: Tests-Disabled
Labels: -Sheriff-Chromium OS-Android
Status: Assigned (was: Untriaged)
This was another one of these:

Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err: java.lang.AssertionError
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at org.chromium.chrome.browser.metrics.UmaUtils.getForegroundStartTime(UmaUtils.java:96)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at org.chromium.chrome.browser.tab.TabWebContentsObserver.didCommitProvisionalLoadForFrame(TabWebContentsObserver.java:211)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at org.chromium.content.browser.webcontents.WebContentsObserverProxy.didCommitProvisionalLoadForFrame(WebContentsObserverProxy.java:
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:41)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at android.os.Handler.dispatchMessage(Handler.java:102)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at android.os.Looper.loop(Looper.java:136)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at android.app.ActivityThread.main(ActivityThread.java:5001)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at java.lang.reflect.Method.invokeNative(Native Method)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at java.lang.reflect.Method.invoke(Method.java:515)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
Device(06c2e068006af1d0) 12-12 19:30:59.159  1489  1489 W System.err:   at dalvik.system.NativeStart.main(Native Method)
Device(06c2e068006af1d0) 12-12 19:30:59.239  1489  1489 F chromium: [FATAL:jni_android.cc(243)] Please include Java exception stack in crash report

Given the failure pattern and the lack of flakes since 673433 was fixed, I'm reenabling this test.
Blockedon: 673433
Cc: dfalcant...@chromium.org
Owner: jbudorick@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/051939157ae783b75ee69130c6ee85031813f261

commit 051939157ae783b75ee69130c6ee85031813f261
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Dec 14 13:59:57 2016

Revert of Disable tabmodel.UndoTabModelTest#testReverseOrderRestore (patchset #1 id:1 of https://codereview.chromium.org/2572753002/ )

Reason for revert:
Reenabling the test.

Original issue's description:
> Disable tabmodel.UndoTabModelTest#testReverseOrderRestore
>
> BUG= 673729 
> TBR=dfalcantara@chromium.org
>
> Committed: https://crrev.com/7eae967f8220868aa2ac64f04a1fb636f97c5aa2
> Cr-Commit-Position: refs/heads/master@{#438158}

TBR=nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 673729 

Review-Url: https://codereview.chromium.org/2570303002
Cr-Commit-Position: refs/heads/master@{#438506}

[modify] https://crrev.com/051939157ae783b75ee69130c6ee85031813f261/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

Status: WontFix (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment