New issue
Advanced search Search tips

Issue 673684 link

Starred by 1 user
Status: Fixed
Owner:
donnd@chromium.org
Closed: Dec 2016
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testPreventHandlingCurrentSelectionModification" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 13 2016 
"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testPreventHandlingCurrentSelectionModification" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygwELEgVGbGFrZSJ4b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmNvbnRleHR1YWxzZWFyY2guQ29udGV4dHVhbFNlYXJjaE1hbmFnZXJUZXN0I3Rlc3RQcmV2ZW50SGFuZGxpbmdDdXJyZW50U2VsZWN0aW9uTW9kaWZpY2F0aW9uDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by grunell@chromium.org, Dec 13 2016 

I  244.584s run_tests_on_device(06b6ee5b00622841)    Failure in testPreventHandlingCurrentSelectionModification:
I  244.584s run_tests_on_device(06b6ee5b00622841)    junit.framework.AssertionFailedError: Panel did not enter PEEKED state. Instead, the current state is CLOSED.
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToEnterState(ContextualSearchManagerTest.java:691)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToPeek(ContextualSearchManagerTest.java:657)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.longPressNode(ContextualSearchManagerTest.java:197)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testPreventHandlingCurrentSelectionModification(ContextualSearchManagerTest.java:2026)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at java.lang.reflect.Method.invokeNative(Native Method)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  244.584s run_tests_on_device(06b6ee5b00622841)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I  244.585s run_tests_on_device(06b6ee5b00622841)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Comment 2 by grunell@chromium.org, Dec 13 2016

Components: Tests>Disabled
Owner: twelling...@chromium.org
Status: Assigned (was: Untriaged)
Disabling test in https://codereview.chromium.org/2573793002/

twellington@: please take a look.

Comment 3 by grunell@chromium.org, Dec 13 2016

Labels: -Sheriff-Chromium OS-Android
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d48bb57ca532f49e31b51a94b3cf099072b8c6

commit 72d48bb57ca532f49e31b51a94b3cf099072b8c6
Author: grunell <grunell@chromium.org>
Date: Tue Dec 13 13:26:54 2016

Disable flaky test org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testPreventHandlingCurrentSelectionModification.

TBR=twellington@chromium.org

BUG= 673684 

Review-Url: https://codereview.chromium.org/2573793002
Cr-Commit-Position: refs/heads/master@{#438153}

[modify] https://crrev.com/72d48bb57ca532f49e31b51a94b3cf099072b8c6/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 5 by twelling...@chromium.org, Dec 13 2016

Cc: twelling...@chromium.org
Owner: donnd@chromium.org
Donn, do you mind taking this one? I think it should be changed to use the new search simulation instead of waitForPeek(). Maybe this is a good opportunity to change all of our tests to the new system?

Comment 6 by donnd@chromium.org, Dec 13 2016

Labels: M-56
I'll take a look.

Comment 7 by donnd@chromium.org, Dec 13 2016

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf56dab37408dfad3152c5e00092ab99f775273

commit eaf56dab37408dfad3152c5e00092ab99f775273
Author: donnd <donnd@chromium.org>
Date: Wed Dec 14 01:43:52 2016

[TTS] Rework a flaky test to use more robust methodology.

Rework testPreventHandlingCurrentSelectionModification to use
simulateLongPressSearch, closePanel, etc.

Hopefully it will be less flaky with these changes.

BUG= 673684 

Review-Url: https://codereview.chromium.org/2574023002
Cr-Commit-Position: refs/heads/master@{#438385}

[modify] https://crrev.com/eaf56dab37408dfad3152c5e00092ab99f775273/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 9 by donnd@chromium.org, Dec 14 2016

Status: Fixed (was: Started)
Looking at flakiness now I think this is essentially fixed.  There's still some flakiness due to crashes that seem to cause lots of tests to fail.  But the main problem in "Android Tests" under chrome.linux seems to have gone away.  https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=ContextualSearchManagerTest%23testPreventHandlingCurrentSelectionModification

Comment 10 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment