New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673678 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 672020
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to add XHR breakpoints/watch expressions in sources of devtools

Project Member Reported by sc00335...@techmahindra.com, Dec 13 2016

Issue description

Chrome Version:57.0.2950.0 dev 
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and open dev tools >> Go to Sources tab , Expand XHR breakpoints and click on "Add breakpoint" + icon to add any breakpoint and observe
(2)Dock dev tools to bottom,expand watch and click + to add watch expression.

NOTE: Able to add watch expressions when dev tools docked to right.

Expected: Should be able to add breakpoints and watch expressions
Actual: Instead just flickering is seen and unable to add it.

This is a regression issue broken in M57.

Manual Bisect info:
=======================
Good Build:57.0.2949.0
Bad Build :57.0.2950.0


 
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.1 using chrome version 57.0.2950.0 

Comment 2 Deleted

Comment 3 by hdodda@chromium.org, Dec 13 2016

Status: Unconfirmed (was: Duplicate)

Comment 4 by hdodda@chromium.org, Dec 13 2016

Cc: hdodda@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build:57.0.2949.0 (Revision : 437811)
Bad Build :57.0.2950.0 (Revision : 438011)

You are probably looking for a change made after 437986 (known good), but no later than 437987 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/41dbdcc8a8f30b9ca4e7869b72a2154ebe64553e..cd3e789d9ae61c3028d05d9e3361198496b45412

From the CL above, assigning the issue to the concern owner 

@dgozman - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2553043003

Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b0a5bee0609df9a5ff6e5c73569ccb265b3fbd

commit 84b0a5bee0609df9a5ff6e5c73569ccb265b3fbd
Author: dgozman <dgozman@chromium.org>
Date: Thu Dec 15 01:22:56 2016

[DevTools] Consume ToolbarButton click.

BUG= 673678 

Review-Url: https://codereview.chromium.org/2580513002
Cr-Commit-Position: refs/heads/master@{#438702}

[modify] https://crrev.com/84b0a5bee0609df9a5ff6e5c73569ccb265b3fbd/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Status: Fixed (was: Assigned)
 Issue 677384  has been merged into this issue.
Labels: TE-Verified-57.0.2970.0 TE-Verified-M57

Tested this issue on windows 7, Mac 10.12.2 & Linux Ubuntu 14.04 using chrome Dev version#57.0.2970.0 with the steps mentioned in comment #0.

Able to add Watch & XHR Breakpoints in sources of dev tools successfully with dock right & dock down mode.

Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thank you.

673678.mp4
2.4 MB View Download

Sign in to add a comment