Issue 673668 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	schenney@chromium.org
Closed:	Dec 2016
Cc:	ajha@chromium.org █ kavvaru@chromium.org █ brajkumar@chromium.org █ durga.behera@chromium.org
Components:	Blink>Layout
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Mac
Pri:	1
Type:	Bug-Regression
ReleaseBlock-Beta M-57 hasbisect-per-revision merge-merged-2950

Regression: Profile icon is seen chopped on Change picture overlay.

Project Member Reported by ratnavar...@techmahindra.com, Dec 13 2016

Issue description

Chrome Version:57.0.2950.0 dev 
OS: Ubuntu 14.04,Windows 
What steps will reproduce the problem?
(1)Launch chrome and sign into chrome.
(2)Goto NTP >> Click on the profile icon present on right corner and observe profile icon


Expected result: There should not be any chopping on the profile icon.
Actual result:Instead, Chopping of profile icon is seen.

This is a Regression issue broken in M-57

Note:Change picture text is also seen missing.

Bisect info:

Good Build:57.0.2949.0
Bad Build :57.0.2950.0

Comment 1 by sc00335...@techmahindra.com, Dec 13 2016

Attaching screenshots for reference..

	Actual_profile icon.png 210 KB View Download

	Expected_profile icon.png 208 KB View Download

Comment 2 by ajha@chromium.org, Dec 13 2016

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)

Able to reproduce the issue on the latest canary(57.0.2950.0) of Mac OS 10.11.6 as well.

Comment 3 by brajkumar@chromium.org, Dec 13 2016

Components: -UI Blink>Layout
Labels: -Needs-Bisect hasbisect-per-revision
Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)

Using the per-revision bisect providing the bisect results,

You are probably looking for a change made after 437947 (known good), but no later than 437948 (first known bad).

CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/8c0be82a912cb5ef954980c924c32b99740f761c..0cfffd46dfaa1ee93d3d667f82b2fb3721078b34

From the CL above, assigning the issue to the concern owner
Review-Url: https://codereview.chromium.org/2194273002

schenney@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 4 by schenney@chromium.org, Dec 13 2016

Revert in progress.

Comment 5 by e...@chromium.org, Dec 13 2016

Status: Started (was: Assigned)

Thanks schenney!

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed8391042f4acb62c7c89898e8dad01f8afb79e4

commit ed8391042f4acb62c7c89898e8dad01f8afb79e4
Author: schenney <schenney@chromium.org>
Date: Tue Dec 13 18:36:56 2016

Revert "Fix border radius on composited children."

This reverts commit https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34

Chrome's sign-in flow is broken as a result of this patch.
Content inside an element with border-radius is not rendering.

Reverted review URL: https://codereview.chromium.org/2194273002

TBR=chrishtr@chromium.org
BUG= 157218 , 673668 ,673725
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569253002
Cr-Commit-Position: refs/heads/master@{#438234}

[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child.html
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor-expected.html
[delete] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor.html
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-composited-child.html
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/ed8391042f4acb62c7c89898e8dad01f8afb79e4/third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13 2016

Labels: merge-merged-2950

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d839ef5c55dd8d388137a55a0bdbc8c57673c3

commit 58d839ef5c55dd8d388137a55a0bdbc8c57673c3
Author: Stephen Chenney <schenney@chromium.org>
Date: Tue Dec 13 19:14:40 2016

Revert "Fix border radius on composited children." on 2950 branch

This reverts commit https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34

Chrome's sign-in flow is broken as a result of this patch.
Content inside an element with border-radius is not rendering.

Reverted review URL: https://codereview.chromium.org/2194273002

TBR=chrishtr@chromium.org
BUG= 157218 , 673668 ,673725
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569253002
Cr-Commit-Position: refs/heads/master@{#438234}
(cherry picked from commit ed8391042f4acb62c7c89898e8dad01f8afb79e4)

Conflicts:
	third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Review-Url: https://codereview.chromium.org/2571743003 .
Cr-Commit-Position: refs/branch-heads/2950@{#6}
Cr-Branched-From: 2c3ecceea409b42c873949bac0aa1acaa80451e3-refs/heads/master@{#438011}

[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child.html
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor-expected.html
[delete] https://crrev.com/e67f9b3395c12f01747246a5fc44836e34b510bd/third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor.html
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-composited-child.html
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.txt
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/58d839ef5c55dd8d388137a55a0bdbc8c57673c3/third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h

Comment 8 by schenney@chromium.org, Dec 13 2016

Status: Fixed (was: Started)

►

Issue 673668 link

Issue metadata

Regression: Profile icon is seen chopped on Change picture overlay.

Issue description

Comment 1 by sc00335...@techmahindra.com, Dec 13 2016

Comment 1 Deleted

Comment 2 by ajha@chromium.org, Dec 13 2016

Comment 2 Deleted

Comment 3 by brajkumar@chromium.org, Dec 13 2016

Comment 3 Deleted

Comment 4 by schenney@chromium.org, Dec 13 2016

Comment 4 Deleted

Comment 5 by e...@chromium.org, Dec 13 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Dec 13 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Dec 13 2016

Comment 7 Deleted

Comment 8 by schenney@chromium.org, Dec 13 2016

Comment 8 Deleted

Sign in to add a comment