New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673667 link

Starred by 1 user
Status: Fixed
Owner:
vitaliii@chromium.org
Closed: Feb 2017
Cc:
ntp-dev+bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Cleanup: snippets_internals_message_handler one list statement brackets

Project Member Reported by vitaliii@chromium.org, Dec 13 2016 
During our transition to having brackets around all one line statements, we forgot about snippets_internals_message_handler.cc.

Comment 1 by vitaliii@chromium.org, Dec 14 2016 

Same for ios code.

Comment 2 by vitaliii@chromium.org, Feb 1 2017

Labels: zine-17-01-30
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e58c4d554ba4dd2c791da9fc132cfaf2e5a47c70

commit e58c4d554ba4dd2c791da9fc132cfaf2e5a47c70
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Feb 02 09:18:52 2017

[NTP::Cleanup] Add brackets in snippets_internals_message_handler.cc.

This CL adds curly brackets to |if|, |for| and |while| in
snippets_internals_message_handler.cc.

BUG= 673667 

Review-Url: https://codereview.chromium.org/2668263002
Cr-Commit-Position: refs/heads/master@{#447730}

[modify] https://crrev.com/e58c4d554ba4dd2c791da9fc132cfaf2e5a47c70/chrome/browser/ui/webui/snippets_internals_message_handler.cc

Comment 4 by vitaliii@chromium.org, Feb 2 2017

Status: Fixed (was: Started)
iOS code seems ok, so I haven't done anything there.
►

Sign in to add a comment