1) Add SectionRanker interface; 2) Add a default constant section ranker implementation (same as CategoryFactory currently); 3) Replace CategoryFactory with a new ranker.
CL https://codereview.chromium.org/2568033005/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7456f5ae0859872c69398b583d6331ed47d70586 commit 7456f5ae0859872c69398b583d6331ed47d70586 Author: vitaliii <vitaliii@chromium.org> Date: Mon Dec 19 11:13:25 2016 [NTP::SectionOrder] Replace CategoryFactory with a category ranker. This CL: 1) Adds CategoryRanker interface; 2) Adds a default constant category ranker implementation (based on CategoryFactory); 3) Replaces CategoryFactory with a new ranker; 4) Factory methods are moved to Category. This is the initial step of moving to personalised section order. BUG= 673659 Review-Url: https://codereview.chromium.org/2568033005 Cr-Commit-Position: refs/heads/master@{#439451} [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/chrome/browser/android/ntp/ntp_snippets_bridge.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/chrome/browser/ntp_snippets/download_suggestions_provider.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/chrome/browser/ntp_snippets/download_suggestions_provider.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category.h [delete] https://crrev.com/216a94bf46972065bc416c85ad0956b7b6eafb9c/components/ntp_snippets/category_factory.cc [delete] https://crrev.com/216a94bf46972065bc416c85ad0956b7b6eafb9c/components/ntp_snippets/category_factory.h [delete] https://crrev.com/216a94bf46972065bc416c85ad0956b7b6eafb9c/components/ntp_snippets/category_factory_unittest.cc [add] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category_rankers/category_ranker.h [add] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category_rankers/constant_category_ranker.cc [add] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category_rankers/constant_category_ranker.h [add] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category_rankers/constant_category_ranker_unittest.cc [add] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category_rankers/mock_category_ranker.cc [add] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category_rankers/mock_category_ranker.h [add] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/category_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/content_suggestions_provider.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/content_suggestions_provider.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/content_suggestions_service_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/remote/ntp_snippets_fetcher.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/remote/ntp_snippets_fetcher.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/remote/ntp_snippets_fetcher_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/remote/remote_suggestions_provider.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/remote/remote_suggestions_provider.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.h [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc [modify] https://crrev.com/7456f5ae0859872c69398b583d6331ed47d70586/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
Comment 1 by vitaliii@chromium.org
, Dec 13 2016