CRAS: system gain should be limited by min and max |
||||||||
Issue descriptionOn chell, set MaxSoftwareGain to "0", run cras_test_client --dump_s Capture Gain (-50.00 - 0.00) : 20.00dB This is because the default gain in cras_system_state.h is 2000. #define DEFAULT_CAPTURE_GAIN 2000 /* 20dB of gain. */ It is set before min/max updated by the selected node in init_device_settings. We should check and adjust gain in system state when min/max is updated.
,
Dec 20 2016
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e22da843f3da70d03889b131b971611ca8a81648 commit e22da843f3da70d03889b131b971611ca8a81648 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Tue Dec 20 11:08:45 2016 CRAS: system_state: Adjust current gain when limit changes When supported gain limit is changed, current gain should be updated too. BUG= chromium:673656 TEST=Use apprtc and switch between internal mic and headset mic. Check cras_test_client --dump_s and see capture gain is changed to be within limit. TEST=make check Change-Id: Ia5f551d6d92fdb7cc90370f933664ae7db407008 Reviewed-on: https://chromium-review.googlesource.com/422709 Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> [modify] https://crrev.com/e22da843f3da70d03889b131b971611ca8a81648/cras/src/server/cras_system_state.c [modify] https://crrev.com/e22da843f3da70d03889b131b971611ca8a81648/cras/src/tests/system_state_unittest.cc
,
Dec 21 2016
Hi Mac, please verify if this works for your new board. Thanks!
,
Dec 22 2016
Re #4, Hi cychiang, Adjusting capture gain works! I will inform others the fixed. Thanks.
,
Dec 23 2016
Need cherry-pick to R56
,
Dec 23 2016
,
Dec 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/d68d712d90d2933c2093af9f0a4440e08057293d commit d68d712d90d2933c2093af9f0a4440e08057293d Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Tue Dec 20 11:08:45 2016 CRAS: system_state: Adjust current gain when limit changes When supported gain limit is changed, current gain should be updated too. BUG= chromium:673656 TEST=Use apprtc and switch between internal mic and headset mic. Check cras_test_client --dump_s and see capture gain is changed to be within limit. TEST=make check Change-Id: Ia5f551d6d92fdb7cc90370f933664ae7db407008 Previous-Reviewed-on: https://chromium-review.googlesource.com/422709 (cherry picked from commit 05afcdc3065652751119ebc18b814f82a0ff52cf) Reviewed-on: https://chromium-review.googlesource.com/422692 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/d68d712d90d2933c2093af9f0a4440e08057293d/cras/src/server/cras_system_state.c [modify] https://crrev.com/d68d712d90d2933c2093af9f0a4440e08057293d/cras/src/tests/system_state_unittest.cc
,
Dec 26 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 27 2016
,
Jan 19 2017
Verified in Chrome OS 9199.0.0, 57.0.2984.0. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by cychiang@chromium.org
, Dec 20 2016