Issue 673636 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	hinoka@chromium.org
Closed:	May 2017
Cc:	hinoka@chromium.org efoo@chromium.org no...@chromium.org
Components:	Infra>Platform>Milo
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Feature

Participants' hotlists:
Milo-bugs-Update3

Build page: hide green radio button

Project Member Reported by estaab@chromium.org, Dec 13 2016

Issue description

A common use case when viewing a build is to scroll down to the red or purple steps, which takes is tedious for large builds. Right now we have a "show hidden" checkbox that could be changed to radio buttons "All", "Most", and "Failing" (or something similar).

Comment 1 by hinoka@chromium.org, Jan 25 2017

Summary: Build page: hide green radio button (was: hide green radio button)

Comment 2 by estaab@chromium.org, Mar 16 2017

 Issue 701857  has been merged into this issue.

Comment 3 by estaab@chromium.org, Mar 16 2017

There was mention of by default compressing consecutive green line items into one element representing multiple where clicking expands them. Either way, the sea of green is a bit too much as it is.

Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/99f8e4b1c4b786ee903f40e5c71012bae7200cd1

commit 99f8e4b1c4b786ee903f40e5c71012bae7200cd1
Author: hinoka <hinoka@google.com>
Date: Mon May 22 18:12:25 2017

Milo: Add an option to hide green steps

This CL contains 2 things
1. Fixes buildbot build reporting of interesting vs normal steps.
2. Client-side hiding of normal steps.  Changed from single checkbox to 3 radio boxes.

BUG= 673636 

Review-Url: https://codereview.chromium.org/2886353002

[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/buildbot/build.go
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/buildbot/expectations/newline.1234.build.json
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/static/buildbot/css/default.css
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/templates/pages/build.html

Project Member

Comment 5 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/99f8e4b1c4b786ee903f40e5c71012bae7200cd1

commit 99f8e4b1c4b786ee903f40e5c71012bae7200cd1
Author: hinoka <hinoka@google.com>
Date: Mon May 22 18:12:25 2017

Milo: Add an option to hide green steps

This CL contains 2 things
1. Fixes buildbot build reporting of interesting vs normal steps.
2. Client-side hiding of normal steps.  Changed from single checkbox to 3 radio boxes.

BUG= 673636 

Review-Url: https://codereview.chromium.org/2886353002

[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/buildbot/build.go
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/buildbot/expectations/newline.1234.build.json
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/static/buildbot/css/default.css
[modify] https://crrev.com/99f8e4b1c4b786ee903f40e5c71012bae7200cd1/milo/appengine/frontend/templates/pages/build.html

Comment 6 by hinoka@chromium.org, May 22 2017

Status: Fixed (was: Available)

This is now live

Comment 7 by estaab@chromium.org, May 22 2017

Nice! Thanks for adding this.

Comment 8 by estaab@chromium.org, May 22 2017

Owner: hinoka@chromium.org

►

Issue 673636 link

Issue metadata

Build page: hide green radio button

Issue description

Comment 1 by hinoka@chromium.org, Jan 25 2017

Comment 1 Deleted

Comment 2 by estaab@chromium.org, Mar 16 2017

Comment 2 Deleted

Comment 3 by estaab@chromium.org, Mar 16 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, May 22 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, May 22 2017

Comment 5 Deleted

Comment 6 by hinoka@chromium.org, May 22 2017

Comment 6 Deleted

Comment 7 by estaab@chromium.org, May 22 2017

Comment 7 Deleted

Comment 8 by estaab@chromium.org, May 22 2017

Comment 8 Deleted

Sign in to add a comment