New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673629 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Move src/ui/app_list into src/ash

Project Member Reported by jamescook@chromium.org, Dec 13 2016

Issue description

It used to ship on Win/Mac/Linux/CrOS, but now it's Chrome OS only.

The code would probably be a little simpler to maintain if it lived in src/ash.

We can also take tapted out of OWNERS.

 
Owner: jamescook@chromium.org
Status: Available (was: Untriaged)
Cc: mfomitchev@chromium.org
tapted/mgiuca, are you guys doing app list cleanup right now? Do you think this is a good idea, and if so, do you guys want to handle it?

I was thinking it might eliminate some delegates, but I don't know the code well.

I think we could eliminate AppListPresenterDelegate, but not AppListViewDelegate or AppListControllerDelegate since they need stuff from src/chrome.

Although I just noticed there is chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc (in src/chrome, but at a glance it looks like it could move out).

There might not be big benefits by moving to src/ash, so I don't think we need to prioritize that.

I haven't got another cleanup in my runqueue just yet. There's some stuff in app_list_service[_impl].cc for async profile loading and process startup which doesn't apply to ChromeOS. And some other stale UMA/prefs to audit.
FYI I don't have cycles for App List cleanup (having moved off that project years ago).

There is still probably some stuff left over from when it was cross-platform, but I think most of the big things have moved away. Moving it into ash would help to clarify ownership and maybe simplify the build rules (since it's just part of ChromeOS).
Mergedinto: 733662
Status: Duplicate (was: Available)
More detailed discussion in the other bug.

Sign in to add a comment