Move src/ui/app_list into src/ash |
||
Issue descriptionIt used to ship on Win/Mac/Linux/CrOS, but now it's Chrome OS only. The code would probably be a little simpler to maintain if it lived in src/ash. We can also take tapted out of OWNERS.
,
Feb 8 2017
,
Apr 4 2017
tapted/mgiuca, are you guys doing app list cleanup right now? Do you think this is a good idea, and if so, do you guys want to handle it? I was thinking it might eliminate some delegates, but I don't know the code well.
,
Apr 4 2017
I think we could eliminate AppListPresenterDelegate, but not AppListViewDelegate or AppListControllerDelegate since they need stuff from src/chrome. Although I just noticed there is chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc (in src/chrome, but at a glance it looks like it could move out). There might not be big benefits by moving to src/ash, so I don't think we need to prioritize that. I haven't got another cleanup in my runqueue just yet. There's some stuff in app_list_service[_impl].cc for async profile loading and process startup which doesn't apply to ChromeOS. And some other stale UMA/prefs to audit.
,
Apr 4 2017
FYI I don't have cycles for App List cleanup (having moved off that project years ago). There is still probably some stuff left over from when it was cross-platform, but I think most of the big things have moved away. Moving it into ash would help to clarify ownership and maybe simplify the build rules (since it's just part of ChromeOS).
,
Jun 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by tbuck...@chromium.org
, Feb 7 2017Status: Available (was: Untriaged)