New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673593 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
cwp



Sign in to add a comment

quipper: spilt out sorting code from quipper::PerfParser::ParseRawEvents

Project Member Reported by sque@chromium.org, Dec 13 2016

Issue description

From dtmoore:

Currently PerfParser::ParseRawEvents provides "two" operations.  1) it uses ProcessEvents to process all of the parsed perf events.  2) it sorts the "raw" perf events stored in the reader.

The sorting code should be pulled out of ParseRawEvents, either into quipper::PerfReader or as a separate call in PerfParser.  The former is preferred since the sorting has nothing to do with the parsing phase and the operation does destructive changes to the reader object.

This would allow callers which don't care about using quipper's parser, but which do want a sorted PerfDataProto, to get just what they need.  (eg code which converts perf to profile proto).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/101f9b690b1e09be7c9527cb328d63cc60e6c453

commit 101f9b690b1e09be7c9527cb328d63cc60e6c453
Author: Simon Que <sque@google.com>
Date: Tue Dec 13 01:26:45 2016

quipper: Move event sorting to PerfReader

The sorting function is being called from PerfParser but doesn't
actually need to be in PerfParser. Move it to PerfReader since it only
fundamentally depends the contents of PerfReader.

BUG= chromium:673593 
TEST=unit tests pass

Change-Id: I698573ad606a4c200259df0befaf00747041abc7
Reviewed-on: https://chromium-review.googlesource.com/419124
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Simon Que <sque@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>

[modify] https://crrev.com/101f9b690b1e09be7c9527cb328d63cc60e6c453/chromiumos-wide-profiling/perf_reader.h
[modify] https://crrev.com/101f9b690b1e09be7c9527cb328d63cc60e6c453/chromiumos-wide-profiling/perf_parser.cc
[modify] https://crrev.com/101f9b690b1e09be7c9527cb328d63cc60e6c453/chromiumos-wide-profiling/perf_parser.h
[modify] https://crrev.com/101f9b690b1e09be7c9527cb328d63cc60e6c453/chromiumos-wide-profiling/perf_reader.cc

Comment 2 by sque@chromium.org, Dec 20 2016

Status: Fixed (was: Started)

Comment 3 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment