Is there a spec/prior art for how to do the shadow? I found the views code, but hoping there's an established way in Cocoa

It might make sense to just do this in Views and ship it with #md-secondary-ui

Ooh interesting - I didn't realise this is so close in appearance to a floating window/bubble. So, it does look possible to do this. The current MD window/animation does compile and "work" on Mac, but it's pretty janky (see attached).

Issues 
 - framerate could be better (partly due to debug build maybe)
 - appears to "pop" in rather than slide (again, partly due to using a debug build in this video, but there's something to optimize/waitfor here)
 - when sliding out, the contents move out over a white background (making the background transparent should fix this, but might have shadow implications)
 - sometimes the WindowServer-drawn window shadow doesn't get invalidated, or doesn't get drawn (I couldn't repro that in this video, but it can happen).

Also plumbing this through for a Cocoa browser could get curly because of possible assumptions around whether the findbar is an NSView versus and NSWindow.

Deleted: md_findbar_mac.mov 1.7 MB

md_findbar_mac.mov 1.7 MB Download

 Issue 726045  has been merged into this issue.

This is waiting on macviews secondary UI, but doesn't need to block Harmony launch, so I'm tagging M-X.

Since we are using the NSView findbar for Harmony Phase 1, this should perhaps be labelled MacViews-Browser. Fixing it separately is not on the agenda AFAIK, so I'm dropping priority.

It also basically works already: See  Issue 646734 .

The *Harmony* bug for this on non-Mac is  Issue 651643 , and it is mostly done.

Unless we are planning to replace the NSView findbar before MacViewsBrowser, I don't think we need to keep this bug open.

This needs a milestone attached to it. We can't have this UI for 69. And I assume we don't want it for MacViews in 67?

This is going to be tied to MacViews-Browser shipping, which is targeted at M69. Once MacViews-Browser ships, this will happen automatically. Does that work, bettes@?

Getting the Views find bar to work with the Cocoa browser window (pre-M69) or getting the Cocoa find bar to look like this would both be undertakings.

MacViews triage: marking this as Target-69 and assigning to myself (to ensure that that happens).

 Issue 48568  has been merged into this issue.

Per c#14, this is really a Cocoa thing.

Can we close this out with MacViews?

yeah I think we can WontFix everything in Hotlist-CocoaBrowser in bulk. (at some point). (if things go to plan). Although there's a lot more.. like, 3 of the bugs blocked on this one that we can probably also close out.

Punting Hotlist-CocoaBrowser to M71, at which point I will mass-close them. NextAction is the M71 branch point.

The NextAction date has arrived: 2018-10-11

Hotlist-CocoaBrowser -> Closed :)