Create security_state::ShouldAlwaysShowIconForSecurityLevel() |
||||
Issue descriptionios_internal has some brittle code (LocationBarViewIOS::OnChanged) that assumes that we want to show the security icon whenever the security level is not NONE. We should take this calculation out and move it to the security_state component, and then use it both on iOS and Android. This way, both platforms will stay in sync with the (public_ security_state component.
,
Dec 13 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ebd14abf5556e940f556b04411cf95937bfb74a commit 6ebd14abf5556e940f556b04411cf95937bfb74a Author: lgarron <lgarron@chromium.org> Date: Wed Dec 14 22:39:08 2016 Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox calculations. BUG= 673530 Review-Url: https://codereview.chromium.org/2574733003 Cr-Commit-Position: refs/heads/master@{#438654} [modify] https://crrev.com/6ebd14abf5556e940f556b04411cf95937bfb74a/components/security_state/core/BUILD.gn [add] https://crrev.com/6ebd14abf5556e940f556b04411cf95937bfb74a/components/security_state/core/security_state_ui.cc [add] https://crrev.com/6ebd14abf5556e940f556b04411cf95937bfb74a/components/security_state/core/security_state_ui.h
,
Dec 14 2016
,
Dec 14 2016
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76c172851a33d32e6eee07701d9ed8821b0e2a30 commit 76c172851a33d32e6eee07701d9ed8821b0e2a30 Author: lgarron <lgarron@chromium.org> Date: Thu Mar 02 22:10:53 2017 Update the Bling omnibox to be aware of HTTP_SHOW_WARNING and use ShouldAlwaysShowIcon(). BUG= 647559 , 673530 Review-Url: https://codereview.chromium.org/2692173002 Cr-Commit-Position: refs/heads/master@{#454399} [modify] https://crrev.com/76c172851a33d32e6eee07701d9ed8821b0e2a30/ios/chrome/browser/ui/omnibox/BUILD.gn [modify] https://crrev.com/76c172851a33d32e6eee07701d9ed8821b0e2a30/ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm [modify] https://crrev.com/76c172851a33d32e6eee07701d9ed8821b0e2a30/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm |
||||
►
Sign in to add a comment |
||||
Comment 1 by lgar...@chromium.org
, Dec 12 2016